a2f1d6959d
* Make most of the functions const correct
Used clang-tidy and sonarlint to help find places where const could
pretty easily applied. Also lot of hand work.
This commit does not yet touch handlers and typedefs of those.
* Fix Arduino uno handler_who_is() has extra parenthesis
For some reason there is extra parenthesis. Remove it this is more
likely buildable.
* Bugfix/bacapp: Fix uninitilized array_index
We have changed bacapp_snprintf_value() to be const correct. After that
we got
```
/home/runner/work/bacnet-stack/bacnet-stack/src/bacnet/bacapp.c:3183:27: warning: 4th function call argument is an uninitialized value [core.CallAndMessage]
ret_val = bacapp_snprintf_weeklyschedule(
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.
```
So analyzer could now spot that we do not actually initilize array_index
at all. Fix this by setting array_index to zero. Note that I actually do
not know if zeroing is right thing to do here. I choose zero as if this
has worked before it is most likely that it will work with zero value.
* cmake: Add and ignore Wwrite-strings compiler option
Wwrite-strings helps find places where const correctness is broken.
Example it will warn about these
```C
void func1(char* str);
func("test") /* "test" is const so we should not pass it to func1().
char* func2()
{
return "test"; /* func2() should return const char*.
}
```
We still need to ignore it as not all are fixed but let's add it already
so we remember that it should be opened at some point.
---------
Co-authored-by: Kari Argillander <kari.argillander@fidelix.com>
364 lines
12 KiB
C
364 lines
12 KiB
C
/**
|
|
* @file
|
|
* @brief command line tool that sends a BACnet Initialize-Routing-Table
|
|
* message to a network and waits for responses. Displays their network
|
|
* information from the response. This is a router-to-router message.
|
|
* @author Steve Karg <skarg@users.sourceforge.net>
|
|
* @date 2008
|
|
* @copyright SPDX-License-Identifier: MIT
|
|
*/
|
|
#include <stddef.h>
|
|
#include <stdint.h>
|
|
#include <stdio.h>
|
|
#include <stdlib.h>
|
|
#include <time.h> /* for time */
|
|
#include <errno.h>
|
|
/* BACnet Stack defines - first */
|
|
#include "bacnet/bacdef.h"
|
|
/* BACnet Stack API */
|
|
#include "bacnet/bactext.h"
|
|
#include "bacnet/iam.h"
|
|
#include "bacnet/npdu.h"
|
|
#include "bacnet/apdu.h"
|
|
#include "bacnet/version.h"
|
|
/* some demo stuff needed */
|
|
#include "bacnet/basic/sys/debug.h"
|
|
#include "bacnet/basic/binding/address.h"
|
|
#include "bacnet/basic/object/device.h"
|
|
#include "bacnet/datalink/datalink.h"
|
|
#include "bacnet/basic/sys/filename.h"
|
|
#include "bacnet/basic/services.h"
|
|
#include "bacnet/basic/tsm/tsm.h"
|
|
#include "bacnet/datalink/dlenv.h"
|
|
|
|
/* buffer used for receive */
|
|
static uint8_t Rx_Buf[MAX_MPDU] = { 0 };
|
|
|
|
/* target address */
|
|
static BACNET_ADDRESS Target_Router_Address;
|
|
/* static BACNET_ROUTER_PORT *Target_Router_Port_List; */
|
|
|
|
#define VIRTUAL_DNET 2709 /* your choice of number here */
|
|
/** The list of DNETs that our router can reach.
|
|
* Only one entry since we don't support downstream routers.
|
|
*/
|
|
int DNET_list[2] = {
|
|
VIRTUAL_DNET, -1 /* Need -1 terminator */
|
|
};
|
|
|
|
static bool Error_Detected = false;
|
|
|
|
static void MyAbortHandler(
|
|
BACNET_ADDRESS *src, uint8_t invoke_id, uint8_t abort_reason, bool server)
|
|
{
|
|
/* FIXME: verify src and invoke id */
|
|
(void)src;
|
|
(void)invoke_id;
|
|
(void)server;
|
|
printf("BACnet Abort: %s\n", bactext_abort_reason_name(abort_reason));
|
|
Error_Detected = true;
|
|
}
|
|
|
|
static void MyRejectHandler(
|
|
BACNET_ADDRESS *src, uint8_t invoke_id, uint8_t reject_reason)
|
|
{
|
|
/* FIXME: verify src and invoke id */
|
|
(void)src;
|
|
(void)invoke_id;
|
|
printf("BACnet Reject: %s\n", bactext_reject_reason_name(reject_reason));
|
|
Error_Detected = true;
|
|
}
|
|
|
|
static void My_Router_Handler(BACNET_ADDRESS *src,
|
|
BACNET_NPDU_DATA *npdu_data,
|
|
uint8_t *npdu, /* PDU data */
|
|
uint16_t npdu_len)
|
|
{
|
|
uint16_t npdu_offset = 0;
|
|
uint16_t dnet = 0;
|
|
uint16_t len = 0;
|
|
uint16_t j = 0;
|
|
unsigned port_mappings = 0;
|
|
unsigned port_id = 0;
|
|
unsigned port_info_len = 0;
|
|
|
|
switch (npdu_data->network_message_type) {
|
|
case NETWORK_MESSAGE_WHO_IS_ROUTER_TO_NETWORK:
|
|
break;
|
|
case NETWORK_MESSAGE_I_AM_ROUTER_TO_NETWORK:
|
|
break;
|
|
case NETWORK_MESSAGE_I_COULD_BE_ROUTER_TO_NETWORK:
|
|
break;
|
|
case NETWORK_MESSAGE_REJECT_MESSAGE_TO_NETWORK:
|
|
break;
|
|
case NETWORK_MESSAGE_ROUTER_BUSY_TO_NETWORK:
|
|
break;
|
|
case NETWORK_MESSAGE_ROUTER_AVAILABLE_TO_NETWORK:
|
|
break;
|
|
case NETWORK_MESSAGE_INIT_RT_TABLE:
|
|
break;
|
|
case NETWORK_MESSAGE_INIT_RT_TABLE_ACK:
|
|
printf("Initialize-Routing-Table-Ack from ");
|
|
for (j = 0; j < MAX_MAC_LEN; j++) {
|
|
if (j < src->mac_len) {
|
|
printf("%02X", src->mac[j]);
|
|
}
|
|
}
|
|
if (npdu_len >= 1) {
|
|
port_mappings = npdu[npdu_offset];
|
|
printf("\nPort Mappings: %u\n", port_mappings);
|
|
npdu_offset++;
|
|
npdu_len--;
|
|
}
|
|
while (npdu_len) {
|
|
if (npdu_len >= 2) {
|
|
len = decode_unsigned16(&npdu[npdu_offset], &dnet);
|
|
printf("DNET=%hu, ", dnet);
|
|
npdu_offset += len;
|
|
npdu_len -= len;
|
|
}
|
|
if (npdu_len >= 1) {
|
|
port_id = npdu[npdu_offset];
|
|
printf("Port ID=%u, ", port_id);
|
|
npdu_offset++;
|
|
npdu_len--;
|
|
}
|
|
if (npdu_len >= 1) {
|
|
port_info_len = npdu[npdu_offset];
|
|
printf("Port Info Length=%u, ", port_info_len);
|
|
npdu_offset++;
|
|
npdu_len--;
|
|
} else {
|
|
port_info_len = 0;
|
|
}
|
|
if (port_info_len) {
|
|
printf("Port Info=\"");
|
|
while (port_info_len) {
|
|
if (npdu_len >= 1) {
|
|
printf("%02X", npdu[npdu_offset]);
|
|
npdu_offset++;
|
|
npdu_len--;
|
|
}
|
|
}
|
|
printf("\"");
|
|
}
|
|
if (npdu_len) {
|
|
printf("\n");
|
|
}
|
|
}
|
|
printf("\n");
|
|
break;
|
|
case NETWORK_MESSAGE_ESTABLISH_CONNECTION_TO_NETWORK:
|
|
break;
|
|
case NETWORK_MESSAGE_DISCONNECT_CONNECTION_TO_NETWORK:
|
|
break;
|
|
default:
|
|
break;
|
|
}
|
|
}
|
|
|
|
static void My_NPDU_Handler(BACNET_ADDRESS *src, /* source address */
|
|
uint8_t *pdu, /* PDU data */
|
|
uint16_t pdu_len)
|
|
{ /* length PDU */
|
|
int apdu_offset = 0;
|
|
BACNET_ADDRESS dest = { 0 };
|
|
BACNET_NPDU_DATA npdu_data = { 0 };
|
|
|
|
apdu_offset = bacnet_npdu_decode(pdu, pdu_len, &dest, src, &npdu_data);
|
|
if (npdu_data.network_layer_message) {
|
|
if (apdu_offset <= pdu_len) {
|
|
My_Router_Handler(src, &npdu_data, &pdu[apdu_offset],
|
|
(uint16_t)(pdu_len - apdu_offset));
|
|
}
|
|
} else if ((apdu_offset > 0) && (apdu_offset <= pdu_len)) {
|
|
if ((npdu_data.protocol_version == BACNET_PROTOCOL_VERSION) &&
|
|
((dest.net == 0) || (dest.net == BACNET_BROADCAST_NETWORK))) {
|
|
/* only handle the version that we know how to handle */
|
|
/* and we are not a router, so ignore messages with
|
|
routing information cause they are not for us */
|
|
apdu_handler(
|
|
src, &pdu[apdu_offset], (uint16_t)(pdu_len - apdu_offset));
|
|
} else {
|
|
if (dest.net) {
|
|
debug_printf("NPDU: DNET=%d. Discarded!\n", dest.net);
|
|
} else {
|
|
debug_printf("NPDU: BACnet Protocol Version=%d. Discarded!\n",
|
|
npdu_data.protocol_version);
|
|
}
|
|
}
|
|
}
|
|
|
|
return;
|
|
}
|
|
|
|
static void Init_Service_Handlers(void)
|
|
{
|
|
Device_Init(NULL);
|
|
/* we need to handle who-is
|
|
to support dynamic device binding to us */
|
|
apdu_set_unconfirmed_handler(SERVICE_UNCONFIRMED_WHO_IS, handler_who_is);
|
|
/* set the handler for all the services we don't implement
|
|
It is required to send the proper reject message... */
|
|
apdu_set_unrecognized_service_handler_handler(handler_unrecognized_service);
|
|
/* we must implement read property - it's required! */
|
|
apdu_set_confirmed_handler(
|
|
SERVICE_CONFIRMED_READ_PROPERTY, handler_read_property);
|
|
/* handle the reply (request) coming back */
|
|
apdu_set_unconfirmed_handler(SERVICE_UNCONFIRMED_I_AM, handler_i_am_add);
|
|
/* handle any errors coming back */
|
|
apdu_set_abort_handler(MyAbortHandler);
|
|
apdu_set_reject_handler(MyRejectHandler);
|
|
}
|
|
|
|
static void print_usage(const char *filename)
|
|
{
|
|
printf("Usage: %s address [DNET ID Len Info]\n", filename);
|
|
printf(" [--version][--help]\n");
|
|
}
|
|
|
|
static void print_help(const char *filename)
|
|
{
|
|
printf(
|
|
"Send BACnet Initialize-Routing-Table message to a network\n"
|
|
"and wait for responses. Displays their network information.\n");
|
|
printf("\n");
|
|
printf("address:\n"
|
|
"MAC address in xx:xx:xx:xx:xx:xx format or IP x.x.x.x:port\n"
|
|
"DNET ID Len Info:\n"
|
|
"Port-info data:\n"
|
|
" DNET:\n"
|
|
" Destination network number 0-65534\n"
|
|
" ID:\n"
|
|
" Port Identifier number 0-255\n"
|
|
" Info:\n"
|
|
" Octet string of data, up to 255 octets\n"
|
|
"To query the complete routing table, do not include any port-info.\n"
|
|
"To query using Initialize-Routing-Table message to 192.168.0.18:\n"
|
|
"%s 192.168.0.18:47808\n",
|
|
filename);
|
|
}
|
|
|
|
static void address_parse(BACNET_ADDRESS *dst, int argc, char *argv[])
|
|
{
|
|
unsigned mac[6];
|
|
unsigned port;
|
|
int count = 0;
|
|
int index = 0;
|
|
|
|
if (argc > 0) {
|
|
count = sscanf(argv[0], "%u.%u.%u.%u:%u", &mac[0], &mac[1], &mac[2],
|
|
&mac[3], &port);
|
|
if (count == 5) {
|
|
dst->mac_len = 6;
|
|
for (index = 0; index < 4; index++) {
|
|
dst->mac[index] = mac[index];
|
|
}
|
|
encode_unsigned16(&dst->mac[4], port);
|
|
} else {
|
|
count = sscanf(argv[0], "%x:%x:%x:%x:%x:%x", &mac[0], &mac[1],
|
|
&mac[2], &mac[3], &mac[4], &mac[5]);
|
|
dst->mac_len = count;
|
|
for (index = 0; index < MAX_MAC_LEN; index++) {
|
|
if (index < count) {
|
|
dst->mac[index] = mac[index];
|
|
} else {
|
|
dst->mac[index] = 0;
|
|
}
|
|
}
|
|
}
|
|
}
|
|
dst->net = 0;
|
|
dst->len = 0;
|
|
for (index = 0; index < MAX_MAC_LEN; index++) {
|
|
dst->adr[index] = 0;
|
|
}
|
|
}
|
|
|
|
int main(int argc, char *argv[])
|
|
{
|
|
BACNET_ADDRESS src = { 0 }; /* address where message came from */
|
|
uint16_t pdu_len = 0;
|
|
unsigned timeout = 100; /* milliseconds */
|
|
time_t total_seconds = 0;
|
|
time_t elapsed_seconds = 0;
|
|
time_t last_seconds = 0;
|
|
time_t current_seconds = 0;
|
|
time_t timeout_seconds = 0;
|
|
int argi = 0;
|
|
const char *filename = NULL;
|
|
|
|
filename = filename_remove_path(argv[0]);
|
|
for (argi = 1; argi < argc; argi++) {
|
|
if (strcmp(argv[argi], "--help") == 0) {
|
|
print_usage(filename);
|
|
print_help(filename);
|
|
exit(0);
|
|
}
|
|
if (strcmp(argv[argi], "--version") == 0) {
|
|
printf("%s %s\n", filename, BACNET_VERSION_TEXT);
|
|
printf("Copyright (C) 2014 by Steve Karg and others.\n"
|
|
"This is free software; see the source for copying "
|
|
"conditions.\n"
|
|
"There is NO warranty; not even for MERCHANTABILITY or\n"
|
|
"FITNESS FOR A PARTICULAR PURPOSE.\n");
|
|
exit(0);
|
|
}
|
|
}
|
|
if (argc < 2) {
|
|
print_usage(filename);
|
|
return 0;
|
|
}
|
|
if ((argc > 1) && (strcmp(argv[1], "--help") == 0)) {
|
|
return 0;
|
|
}
|
|
/* decode the command line parameters */
|
|
address_parse(&Target_Router_Address, argc - 1, &argv[1]);
|
|
if (argc > 2) {
|
|
/* FIXME: add port info parse */
|
|
/* BACNET_ROUTER_PORT *router_port_list
|
|
Target_Router_Port_List
|
|
ports_parse(&router_port[0], argc-2, &argv[2]);
|
|
Target_Router_Port_List = router_port[0];
|
|
*/
|
|
}
|
|
/* setup my info */
|
|
Device_Set_Object_Instance_Number(BACNET_MAX_INSTANCE);
|
|
Init_Service_Handlers();
|
|
address_init();
|
|
dlenv_init();
|
|
atexit(datalink_cleanup);
|
|
/* configure the timeout values */
|
|
last_seconds = time(NULL);
|
|
timeout_seconds = apdu_timeout() / 1000;
|
|
/* send the request */
|
|
Send_Initialize_Routing_Table(&Target_Router_Address, DNET_list);
|
|
/* loop forever */
|
|
for (;;) {
|
|
/* increment timer - exit if timed out */
|
|
current_seconds = time(NULL);
|
|
/* returns 0 bytes on timeout */
|
|
pdu_len = datalink_receive(&src, &Rx_Buf[0], MAX_MPDU, timeout);
|
|
/* process */
|
|
if (pdu_len) {
|
|
My_NPDU_Handler(&src, &Rx_Buf[0], pdu_len);
|
|
}
|
|
if (Error_Detected) {
|
|
break;
|
|
}
|
|
/* increment timer - exit if timed out */
|
|
elapsed_seconds = current_seconds - last_seconds;
|
|
if (elapsed_seconds) {
|
|
datalink_maintenance_timer(elapsed_seconds);
|
|
}
|
|
total_seconds += elapsed_seconds;
|
|
if (total_seconds > timeout_seconds) {
|
|
break;
|
|
}
|
|
/* keep track of time for next check */
|
|
last_seconds = current_seconds;
|
|
}
|
|
|
|
return 0;
|
|
}
|