Kari Argillander
a2f1d6959d
* Make most of the functions const correct
Used clang-tidy and sonarlint to help find places where const could
pretty easily applied. Also lot of hand work.
This commit does not yet touch handlers and typedefs of those.
* Fix Arduino uno handler_who_is() has extra parenthesis
For some reason there is extra parenthesis. Remove it this is more
likely buildable.
* Bugfix/bacapp: Fix uninitilized array_index
We have changed bacapp_snprintf_value() to be const correct. After that
we got
```
/home/runner/work/bacnet-stack/bacnet-stack/src/bacnet/bacapp.c:3183:27: warning: 4th function call argument is an uninitialized value [core.CallAndMessage]
ret_val = bacapp_snprintf_weeklyschedule(
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.
```
So analyzer could now spot that we do not actually initilize array_index
at all. Fix this by setting array_index to zero. Note that I actually do
not know if zeroing is right thing to do here. I choose zero as if this
has worked before it is most likely that it will work with zero value.
* cmake: Add and ignore Wwrite-strings compiler option
Wwrite-strings helps find places where const correctness is broken.
Example it will warn about these
```C
void func1(char* str);
func("test") /* "test" is const so we should not pass it to func1().
char* func2()
{
return "test"; /* func2() should return const char*.
}
```
We still need to ignore it as not all are fixed but let's add it already
so we remember that it should be opened at some point.
---------
Co-authored-by: Kari Argillander <kari.argillander@fidelix.com>
58 lines
1.0 KiB
C
58 lines
1.0 KiB
C
/**
|
|
* @file
|
|
* @brief Stub functions for unit test of a BACnet object
|
|
* @author Steve Karg <skarg@users.sourceforge.net>
|
|
* @date December 2022
|
|
*
|
|
* SPDX-License-Identifier: MIT
|
|
*/
|
|
#include <stdbool.h>
|
|
#include <stdint.h>
|
|
#include "bacnet/datetime.h"
|
|
#include "bacnet/bacdef.h"
|
|
#include "bacnet/npdu.h"
|
|
#include "bacnet/basic/object/nc.h"
|
|
|
|
uint32_t Device_Object_Instance_Number(void)
|
|
{
|
|
return 0;
|
|
}
|
|
|
|
int Send_UEvent_Notify(
|
|
uint8_t *buffer,
|
|
const BACNET_EVENT_NOTIFICATION_DATA *data,
|
|
BACNET_ADDRESS *dest)
|
|
{
|
|
(void)buffer;
|
|
(void)data;
|
|
(void)dest;
|
|
return 0;
|
|
}
|
|
|
|
uint8_t
|
|
Send_CEvent_Notify(uint32_t device_id, BACNET_EVENT_NOTIFICATION_DATA *data)
|
|
{
|
|
(void)device_id;
|
|
(void)data;
|
|
return 0;
|
|
}
|
|
|
|
void Send_WhoIs(int32_t low_limit, int32_t high_limit)
|
|
{
|
|
(void)low_limit;
|
|
(void)high_limit;
|
|
}
|
|
|
|
bool datetime_local(
|
|
BACNET_DATE *bdate,
|
|
BACNET_TIME *btime,
|
|
int16_t *utc_offset_minutes,
|
|
bool *dst_active)
|
|
{
|
|
(void)bdate;
|
|
(void)btime;
|
|
(void)utc_offset_minutes;
|
|
(void)dst_active;
|
|
return true;
|
|
}
|