Kari Argillander
a2f1d6959d
* Make most of the functions const correct
Used clang-tidy and sonarlint to help find places where const could
pretty easily applied. Also lot of hand work.
This commit does not yet touch handlers and typedefs of those.
* Fix Arduino uno handler_who_is() has extra parenthesis
For some reason there is extra parenthesis. Remove it this is more
likely buildable.
* Bugfix/bacapp: Fix uninitilized array_index
We have changed bacapp_snprintf_value() to be const correct. After that
we got
```
/home/runner/work/bacnet-stack/bacnet-stack/src/bacnet/bacapp.c:3183:27: warning: 4th function call argument is an uninitialized value [core.CallAndMessage]
ret_val = bacapp_snprintf_weeklyschedule(
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.
```
So analyzer could now spot that we do not actually initilize array_index
at all. Fix this by setting array_index to zero. Note that I actually do
not know if zeroing is right thing to do here. I choose zero as if this
has worked before it is most likely that it will work with zero value.
* cmake: Add and ignore Wwrite-strings compiler option
Wwrite-strings helps find places where const correctness is broken.
Example it will warn about these
```C
void func1(char* str);
func("test") /* "test" is const so we should not pass it to func1().
char* func2()
{
return "test"; /* func2() should return const char*.
}
```
We still need to ignore it as not all are fixed but let's add it already
so we remember that it should be opened at some point.
---------
Co-authored-by: Kari Argillander <kari.argillander@fidelix.com>
123 lines
3.3 KiB
C
123 lines
3.3 KiB
C
/*
|
|
* Copyright (c) 2020 Legrand North America, LLC.
|
|
*
|
|
* SPDX-License-Identifier: MIT
|
|
*/
|
|
|
|
/* @file
|
|
* @brief test BACnet integer encode/decode APIs
|
|
*/
|
|
|
|
#include <zephyr/ztest.h>
|
|
#include <bacnet/bacdef.h>
|
|
#include <bacnet/whois.h>
|
|
|
|
/**
|
|
* @addtogroup bacnet_tests
|
|
* @{
|
|
*/
|
|
|
|
/**
|
|
* @brief Test
|
|
*/
|
|
static int whois_decode_apdu(
|
|
const uint8_t *apdu,
|
|
unsigned apdu_len,
|
|
int32_t *pLow_limit,
|
|
int32_t *pHigh_limit)
|
|
{
|
|
int len = 0;
|
|
|
|
if (!apdu) {
|
|
return BACNET_STATUS_ERROR;
|
|
}
|
|
/* optional limits - must be used as a pair */
|
|
if (apdu_len >= 2) {
|
|
/* optional checking - most likely was already done prior to this call
|
|
*/
|
|
if (apdu[0] != PDU_TYPE_UNCONFIRMED_SERVICE_REQUEST) {
|
|
return BACNET_STATUS_ERROR;
|
|
}
|
|
if (apdu[1] != SERVICE_UNCONFIRMED_WHO_IS) {
|
|
return BACNET_STATUS_ERROR;
|
|
}
|
|
len = whois_decode_service_request(
|
|
&apdu[2], apdu_len - 2, pLow_limit, pHigh_limit);
|
|
}
|
|
|
|
return len;
|
|
}
|
|
|
|
#if defined(CONFIG_ZTEST_NEW_API)
|
|
ZTEST(whois_tests, testWhoIs)
|
|
#else
|
|
static void testWhoIs(void)
|
|
#endif
|
|
{
|
|
uint8_t apdu[480] = { 0 };
|
|
int len = 0;
|
|
int apdu_len = 0;
|
|
int32_t low_limit = -1;
|
|
int32_t high_limit = -1;
|
|
int32_t test_low_limit = 0;
|
|
int32_t test_high_limit = 0;
|
|
|
|
/* normal who-is without limits */
|
|
len = whois_encode_apdu(&apdu[0], low_limit, high_limit);
|
|
zassert_true(len > 0, NULL);
|
|
apdu_len = len;
|
|
|
|
len = whois_decode_apdu(
|
|
&apdu[0], apdu_len, &test_low_limit, &test_high_limit);
|
|
zassert_not_equal(len, BACNET_STATUS_ERROR, NULL);
|
|
zassert_equal(test_low_limit, low_limit, NULL);
|
|
zassert_equal(test_high_limit, high_limit, NULL);
|
|
|
|
/* normal who-is with limits - complete range */
|
|
for (low_limit = 0; low_limit <= BACNET_MAX_INSTANCE;
|
|
low_limit += (BACNET_MAX_INSTANCE / 4)) {
|
|
for (high_limit = 0; high_limit <= BACNET_MAX_INSTANCE;
|
|
high_limit += (BACNET_MAX_INSTANCE / 4)) {
|
|
len = whois_encode_apdu(&apdu[0], low_limit, high_limit);
|
|
apdu_len = len;
|
|
zassert_true(len > 0, NULL);
|
|
len = whois_decode_apdu(
|
|
&apdu[0], apdu_len, &test_low_limit, &test_high_limit);
|
|
zassert_not_equal(len, BACNET_STATUS_ERROR, NULL);
|
|
zassert_equal(test_low_limit, low_limit, NULL);
|
|
zassert_equal(test_high_limit, high_limit, NULL);
|
|
}
|
|
}
|
|
/* abnormal case:
|
|
who-is with no limits, but with APDU containing 2 limits */
|
|
low_limit = 0;
|
|
high_limit = 0;
|
|
len = whois_encode_apdu(&apdu[0], low_limit, high_limit);
|
|
zassert_true(len > 0, NULL);
|
|
apdu_len = len;
|
|
low_limit = -1;
|
|
high_limit = -1;
|
|
len = whois_encode_apdu(&apdu[0], low_limit, high_limit);
|
|
zassert_true(len > 0, NULL);
|
|
apdu_len = len;
|
|
len = whois_decode_apdu(
|
|
&apdu[0], apdu_len, &test_low_limit, &test_high_limit);
|
|
zassert_not_equal(len, BACNET_STATUS_ERROR, NULL);
|
|
zassert_equal(test_low_limit, low_limit, NULL);
|
|
zassert_equal(test_high_limit, high_limit, NULL);
|
|
}
|
|
/**
|
|
* @}
|
|
*/
|
|
|
|
#if defined(CONFIG_ZTEST_NEW_API)
|
|
ZTEST_SUITE(whois_tests, NULL, NULL, NULL, NULL, NULL);
|
|
#else
|
|
void test_main(void)
|
|
{
|
|
ztest_test_suite(whois_tests, ztest_unit_test(testWhoIs));
|
|
|
|
ztest_run_test_suite(whois_tests);
|
|
}
|
|
#endif
|