Kari Argillander
a2f1d6959d
* Make most of the functions const correct
Used clang-tidy and sonarlint to help find places where const could
pretty easily applied. Also lot of hand work.
This commit does not yet touch handlers and typedefs of those.
* Fix Arduino uno handler_who_is() has extra parenthesis
For some reason there is extra parenthesis. Remove it this is more
likely buildable.
* Bugfix/bacapp: Fix uninitilized array_index
We have changed bacapp_snprintf_value() to be const correct. After that
we got
```
/home/runner/work/bacnet-stack/bacnet-stack/src/bacnet/bacapp.c:3183:27: warning: 4th function call argument is an uninitialized value [core.CallAndMessage]
ret_val = bacapp_snprintf_weeklyschedule(
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.
```
So analyzer could now spot that we do not actually initilize array_index
at all. Fix this by setting array_index to zero. Note that I actually do
not know if zeroing is right thing to do here. I choose zero as if this
has worked before it is most likely that it will work with zero value.
* cmake: Add and ignore Wwrite-strings compiler option
Wwrite-strings helps find places where const correctness is broken.
Example it will warn about these
```C
void func1(char* str);
func("test") /* "test" is const so we should not pass it to func1().
char* func2()
{
return "test"; /* func2() should return const char*.
}
```
We still need to ignore it as not all are fixed but let's add it already
so we remember that it should be opened at some point.
---------
Co-authored-by: Kari Argillander <kari.argillander@fidelix.com>
143 lines
2.9 KiB
C
143 lines
2.9 KiB
C
/*
|
|
* Copyright (c) 2020 Legrand North America, LLC.
|
|
*
|
|
* SPDX-License-Identifier: MIT
|
|
*/
|
|
|
|
#include <zephyr/ztest.h>
|
|
#include <stdint.h> /* for standard integer types uint8_t etc. */
|
|
#include <stdbool.h> /* for the standard bool type. */
|
|
#include <stdio.h>
|
|
#include <string.h>
|
|
#include <stdlib.h>
|
|
#include <stdio.h>
|
|
#include "bacnet/datalink/bip.h"
|
|
|
|
bool bip_init(char *ifname)
|
|
{
|
|
ztest_check_expected_value(ifname);
|
|
return ztest_get_return_value();
|
|
}
|
|
|
|
void bip_set_interface(const char *ifname)
|
|
{
|
|
ztest_check_expected_value(ifname);
|
|
}
|
|
|
|
void bip_cleanup(void)
|
|
{
|
|
}
|
|
|
|
bool bip_valid(void)
|
|
{
|
|
return ztest_get_return_value();
|
|
}
|
|
|
|
bool bip_get_broadcast_addr(BACNET_IP_ADDRESS *addr)
|
|
{
|
|
ztest_copy_return_data(addr, sizeof(BACNET_IP_ADDRESS));
|
|
return ztest_get_return_value();
|
|
}
|
|
|
|
void bip_get_my_address(BACNET_ADDRESS *my_address)
|
|
{
|
|
ztest_copy_return_data(my_address, sizeof(BACNET_ADDRESS));
|
|
}
|
|
|
|
int bip_send_pdu(
|
|
BACNET_ADDRESS *dest,
|
|
BACNET_NPDU_DATA *npdu_data,
|
|
uint8_t *pdu,
|
|
unsigned pdu_len)
|
|
{
|
|
ztest_check_expected_value(dest);
|
|
ztest_check_expected_value(npdu_data);
|
|
ztest_check_expected_data(pdu, pdu_len);
|
|
return ztest_get_return_value();
|
|
}
|
|
|
|
int bip_send_mpdu(
|
|
const BACNET_IP_ADDRESS *dest, const uint8_t *mtu, uint16_t mtu_len)
|
|
{
|
|
ztest_check_expected_value(dest);
|
|
ztest_check_expected_data(mtu, mtu_len);
|
|
return ztest_get_return_value();
|
|
}
|
|
|
|
uint16_t bip_receive(
|
|
BACNET_ADDRESS *src, uint8_t *pdu, uint16_t max_pdu, unsigned timeout)
|
|
{
|
|
ztest_check_expected_value(src);
|
|
ztest_check_expected_value(timeout);
|
|
ztest_copy_return_data(pdu, max_pdu);
|
|
return ztest_get_return_value();
|
|
}
|
|
|
|
void bip_set_port(uint16_t port)
|
|
{
|
|
ztest_check_expected_value(port);
|
|
}
|
|
|
|
bool bip_port_changed(void)
|
|
{
|
|
return ztest_get_return_value();
|
|
}
|
|
|
|
uint16_t bip_get_port(void)
|
|
{
|
|
return ztest_get_return_value();
|
|
}
|
|
|
|
bool bip_set_addr(const BACNET_IP_ADDRESS *addr)
|
|
{
|
|
ztest_check_expected_data(addr, sizeof(BACNET_IP_ADDRESS));
|
|
return ztest_get_return_value();
|
|
}
|
|
|
|
bool bip_get_addr(BACNET_IP_ADDRESS *addr)
|
|
{
|
|
ztest_copy_return_data(addr, sizeof(BACNET_IP_ADDRESS));
|
|
return ztest_get_return_value();
|
|
}
|
|
|
|
bool bip_get_addr_by_name(const char *host_name, BACNET_IP_ADDRESS *addr)
|
|
{
|
|
ztest_check_expected_value(host_name);
|
|
ztest_check_expected_value(addr);
|
|
return ztest_get_return_value();
|
|
}
|
|
|
|
void bip_get_broadcast_address(BACNET_ADDRESS *dest)
|
|
{
|
|
ztest_copy_return_data(dest, sizeof(BACNET_ADDRESS));
|
|
}
|
|
|
|
bool bip_set_broadcast_addr(const BACNET_IP_ADDRESS *addr)
|
|
{
|
|
return ztest_get_return_value();
|
|
}
|
|
|
|
bool bip_set_subnet_prefix(uint8_t prefix)
|
|
{
|
|
return false;
|
|
}
|
|
|
|
uint8_t bip_get_subnet_prefix(void)
|
|
{
|
|
return ztest_get_return_value();
|
|
}
|
|
|
|
void bip_debug_enable(void)
|
|
{
|
|
}
|
|
|
|
int bip_get_socket(void)
|
|
{
|
|
return ztest_get_return_value();
|
|
}
|
|
|
|
int bip_get_broadcast_socket(void)
|
|
{
|
|
return ztest_get_return_value();
|
|
}
|