Kari Argillander
a2f1d6959d
* Make most of the functions const correct
Used clang-tidy and sonarlint to help find places where const could
pretty easily applied. Also lot of hand work.
This commit does not yet touch handlers and typedefs of those.
* Fix Arduino uno handler_who_is() has extra parenthesis
For some reason there is extra parenthesis. Remove it this is more
likely buildable.
* Bugfix/bacapp: Fix uninitilized array_index
We have changed bacapp_snprintf_value() to be const correct. After that
we got
```
/home/runner/work/bacnet-stack/bacnet-stack/src/bacnet/bacapp.c:3183:27: warning: 4th function call argument is an uninitialized value [core.CallAndMessage]
ret_val = bacapp_snprintf_weeklyschedule(
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.
```
So analyzer could now spot that we do not actually initilize array_index
at all. Fix this by setting array_index to zero. Note that I actually do
not know if zeroing is right thing to do here. I choose zero as if this
has worked before it is most likely that it will work with zero value.
* cmake: Add and ignore Wwrite-strings compiler option
Wwrite-strings helps find places where const correctness is broken.
Example it will warn about these
```C
void func1(char* str);
func("test") /* "test" is const so we should not pass it to func1().
char* func2()
{
return "test"; /* func2() should return const char*.
}
```
We still need to ignore it as not all are fixed but let's add it already
so we remember that it should be opened at some point.
---------
Co-authored-by: Kari Argillander <kari.argillander@fidelix.com>
108 lines
3.2 KiB
C
108 lines
3.2 KiB
C
/**
|
|
* @file
|
|
* @author Steve Karg
|
|
* @date 2009
|
|
* @brief System time library header file.
|
|
*
|
|
* @section DESCRIPTION
|
|
*
|
|
* This library provides functions for getting and setting the system time.
|
|
*/
|
|
#include <stdio.h>
|
|
#include <stdlib.h>
|
|
#include <time.h>
|
|
#include <stdbool.h>
|
|
#include <stdint.h>
|
|
#include <stdlib.h>
|
|
#include <time.h>
|
|
#include "bacnet/basic/service/h_ts.h"
|
|
#include "bacport.h"
|
|
#include "bacnet/datetime.h"
|
|
|
|
|
|
/**
|
|
* @brief Set offset from the system clock.
|
|
* @param bdate BACnet Date structure to hold local time
|
|
* @param btime BACnet Time structure to hold local time
|
|
* @param utc - True for UTC sync, False for Local time
|
|
* @return True if time is set
|
|
*/
|
|
void datetime_timesync(BACNET_DATE *bdate, BACNET_TIME *btime, bool utc)
|
|
{
|
|
(void)bdate;
|
|
(void)btime;
|
|
(void)utc;
|
|
return;
|
|
}
|
|
|
|
/**
|
|
* @brief Get the date, time, timezone, and UTC offset from system
|
|
* @param utc_time - the BACnet Date and Time structure to hold UTC time
|
|
* @param local_time - the BACnet Date and Time structure to hold local time
|
|
* @param utc_offset_minutes - number of minutes offset from UTC
|
|
* For example, -6*60 represents 6.00 hours behind UTC/GMT
|
|
* @param true if DST is enabled and active
|
|
* @return true if local time was retrieved
|
|
*/
|
|
bool datetime_local(BACNET_DATE *bdate,
|
|
BACNET_TIME *btime,
|
|
int16_t *utc_offset_minutes,
|
|
bool *dst_active)
|
|
{
|
|
bool status = false;
|
|
struct tm *tblock = NULL;
|
|
struct timeval tv;
|
|
|
|
if (gettimeofday(&tv, NULL) == 0) {
|
|
tblock = (struct tm *)localtime((const time_t *)&tv.tv_sec);
|
|
}
|
|
if (tblock) {
|
|
status = true;
|
|
/** struct tm
|
|
* int tm_sec Seconds [0,60].
|
|
* int tm_min Minutes [0,59].
|
|
* int tm_hour Hour [0,23].
|
|
* int tm_mday Day of month [1,31].
|
|
* int tm_mon Month of year [0,11].
|
|
* int tm_year Years since 1900.
|
|
* int tm_wday Day of week [0,6] (Sunday =0).
|
|
* int tm_yday Day of year [0,365].
|
|
* int tm_isdst Daylight Savings flag.
|
|
* long tm_gmtoff offset from UTC in seconds
|
|
*/
|
|
datetime_set_date(bdate, (uint16_t)tblock->tm_year + 1900,
|
|
(uint8_t)tblock->tm_mon + 1, (uint8_t)tblock->tm_mday);
|
|
datetime_set_time(btime, (uint8_t)tblock->tm_hour,
|
|
(uint8_t)tblock->tm_min, (uint8_t)tblock->tm_sec,
|
|
(uint8_t)(tv.tv_usec / 10000));
|
|
if (dst_active) {
|
|
/* The value of tm_isdst is:
|
|
- positive if Daylight Saving Time is in effect,
|
|
- 0 if Daylight Saving Time is not in effect, and
|
|
- negative if the information is not available. */
|
|
if (tblock->tm_isdst > 0) {
|
|
*dst_active = true;
|
|
} else {
|
|
*dst_active = false;
|
|
}
|
|
}
|
|
/* note: timezone is declared in <time.h> stdlib. */
|
|
if (utc_offset_minutes) {
|
|
/* tm_gmtoff is set to the difference, in seconds,
|
|
between Coordinated Universal Time (UTC) and
|
|
local standard time */
|
|
*utc_offset_minutes = tblock->tm_gmtoff / 60;
|
|
}
|
|
}
|
|
|
|
return status;
|
|
}
|
|
|
|
/**
|
|
* initialize the date time
|
|
*/
|
|
void datetime_init(void)
|
|
{
|
|
/* nothing to do */
|
|
}
|