From fa445a1251b1d1482e4bf393a205bbd2b5a07587 Mon Sep 17 00:00:00 2001
From: skarg <skarg@1e814d3a-8a88-4260-be86-c0dc25669c1e>
Date: Wed, 15 Feb 2017 21:50:06 +0000
Subject: [PATCH] Fixed warnings detected by splint

---
 bacnet-stack/splint.sh     | 3 ++-
 bacnet-stack/src/address.c | 2 +-
 bacnet-stack/src/apdu.c    | 2 +-
 bacnet-stack/src/awf.c     | 4 ++--
 4 files changed, 6 insertions(+), 5 deletions(-)

diff --git a/bacnet-stack/splint.sh b/bacnet-stack/splint.sh
index b4bd39ae..f91ebb42 100755
--- a/bacnet-stack/splint.sh
+++ b/bacnet-stack/splint.sh
@@ -20,7 +20,8 @@ rm -f splint_output.txt
 touch splint_output.txt
 for filename in $( find $directory -name '*.c' )
 do
-  echo splinting ${filename} >> ${SPLINT_LOGFILE}
+  echo splinting ${filename}
+  echo splinting ${filename} >> ${SPLINT_LOGFILE} 
   ${SPLINT} ${filename} >> ${SPLINT_LOGFILE} 2>&1
 done
 
diff --git a/bacnet-stack/src/address.c b/bacnet-stack/src/address.c
index 3a0d9273..c982ce70 100644
--- a/bacnet-stack/src/address.c
+++ b/bacnet-stack/src/address.c
@@ -126,7 +126,7 @@ void address_remove_device(
     uint32_t device_id)
 {
     struct Address_Cache_Entry *pMatch;
-    int index = 0;
+    uint32_t index = 0;
 
     pMatch = Address_Cache;
     while (pMatch <= &Address_Cache[MAX_ADDRESS_CACHE - 1]) {
diff --git a/bacnet-stack/src/apdu.c b/bacnet-stack/src/apdu.c
index 22200519..9dc93e67 100644
--- a/bacnet-stack/src/apdu.c
+++ b/bacnet-stack/src/apdu.c
@@ -462,7 +462,7 @@ void apdu_handler(
         /* PDU Type */
         switch (apdu[0] & 0xF0) {
             case PDU_TYPE_CONFIRMED_SERVICE_REQUEST:
-                apdu_decode_confirmed_service_request(&apdu[0],
+                (void)apdu_decode_confirmed_service_request(&apdu[0],
                     apdu_len, &service_data, &service_choice, &service_request,
                     &service_request_len);
                 if (apdu_confirmed_dcc_disabled(service_choice)) {
diff --git a/bacnet-stack/src/awf.c b/bacnet-stack/src/awf.c
index 3eadc167..0fe449cb 100644
--- a/bacnet-stack/src/awf.c
+++ b/bacnet-stack/src/awf.c
@@ -139,7 +139,7 @@ int awf_decode_service_request(
             decoded_len =
                 decode_octet_string(&apdu[len], len_value_type,
                 &data->fileData[0]);
-            if (decoded_len != len_value_type) {
+            if ((uint32_t)decoded_len != len_value_type) {
                 return -1;
             }
             len += decoded_len;
@@ -181,7 +181,7 @@ int awf_decode_service_request(
                 decoded_len =
                     decode_octet_string(&apdu[len], len_value_type,
                     &data->fileData[i]);
-                if (decoded_len != len_value_type) {
+                if ((uint32_t)decoded_len != len_value_type) {
                     return -1;
                 }
                 len += decoded_len;