Fix (most) compilation warnings in Intel C++ Compiler (#38)

* Use BACNET_OBJECT_TYPE for all object type variables.

* Fix ICC "mixing enumerated type" warnings for assignments and parameters.

* Network Port: Use enums for state structs and remove erroneous bounds checks copy-pasted from IP_Subnet_Prefix setter.

* Fix ICC "unreachable statement" warnings.

* Fix ICC "unused variable" warnings when printing is disabled.

* Fix ICC "mixing enumerated type" warnings for struct initializers { 0 } by ensuring the first member is an integer type.

* Send_GetEvent_Global: Return 0 (invalid TSM invoke ID) instead of -1 = 255 (technically valid invoke ID) on failure.

* Fix ICC "pointless comparison" warnings.

* Fix wrong import in objects.c (memset being used).

* Fix signedness warnings and inconsistencies. Include -1 = 255 check in cov_address_get().

* Add some guards for BACAPP_LIGHTING_COMMAND to avoid errors/warnings.

* RPM test fixes

* Address requested changes. (#38)

src/bacnet/ihave.c

@@ -50,11 +50,11 @@ int ihave_encode_apdu(uint8_t *apdu, BACNET_I_HAVE_DATA *data)
         apdu_len = 2;
         /* deviceIdentifier */
         len = encode_application_object_id(&apdu[apdu_len],
-            (int)data->device_id.type, data->device_id.instance);
+            data->device_id.type, data->device_id.instance);
         apdu_len += len;
         /* objectIdentifier */
         len = encode_application_object_id(&apdu[apdu_len],
-            (int)data->object_id.type, data->object_id.instance);
+            data->object_id.type, data->object_id.instance);
         apdu_len += len;
         /* objectName */
         len = encode_application_character_string(
@@ -74,7 +74,7 @@ int ihave_decode_service_request(
     int len = 0;
     uint8_t tag_number = 0;
     uint32_t len_value = 0;
-    uint16_t decoded_type = 0; /* for decoding */
+    BACNET_OBJECT_TYPE decoded_type = OBJECT_NONE; /* for decoding */
 
     if (apdu_len && data) {
         /* deviceIdentifier */