Fix (most) compilation warnings in Intel C++ Compiler (#38)

* Use BACNET_OBJECT_TYPE for all object type variables.

* Fix ICC "mixing enumerated type" warnings for assignments and parameters.

* Network Port: Use enums for state structs and remove erroneous bounds checks copy-pasted from IP_Subnet_Prefix setter.

* Fix ICC "unreachable statement" warnings.

* Fix ICC "unused variable" warnings when printing is disabled.

* Fix ICC "mixing enumerated type" warnings for struct initializers { 0 } by ensuring the first member is an integer type.

* Send_GetEvent_Global: Return 0 (invalid TSM invoke ID) instead of -1 = 255 (technically valid invoke ID) on failure.

* Fix ICC "pointless comparison" warnings.

* Fix wrong import in objects.c (memset being used).

* Fix signedness warnings and inconsistencies. Include -1 = 255 check in cov_address_get().

* Add some guards for BACAPP_LIGHTING_COMMAND to avoid errors/warnings.

* RPM test fixes

* Address requested changes. (#38)

This commit is contained in:

Geert Linders

2020-01-23 15:18:47 +01:00

committed by

Steve Karg

parent 76abcaedd1

commit f8ce70470c

92 changed files with 438 additions and 263 deletions

									
										src/bacnet/basic/object/objects.c
									
		+1
		-1
	
												View File
												
				@@ -35,7 +35,7 @@

				#include <stddef.h>

				#include <stdlib.h>

				#include <stdio.h>

				#include <memory.h>

				#include <string.h>

				#include "bacnet/basic/sys/keylist.h"

				#include "bacnet/basic/object/objects.h"