Fix (most) compilation warnings in Intel C++ Compiler (#38)
* Use BACNET_OBJECT_TYPE for all object type variables.
* Fix ICC "mixing enumerated type" warnings for assignments and parameters.
* Network Port: Use enums for state structs and remove erroneous bounds checks copy-pasted from IP_Subnet_Prefix setter.
* Fix ICC "unreachable statement" warnings.
* Fix ICC "unused variable" warnings when printing is disabled.
* Fix ICC "mixing enumerated type" warnings for struct initializers { 0 } by ensuring the first member is an integer type.
* Send_GetEvent_Global: Return 0 (invalid TSM invoke ID) instead of -1 = 255 (technically valid invoke ID) on failure.
* Fix ICC "pointless comparison" warnings.
* Fix wrong import in objects.c (memset being used).
* Fix signedness warnings and inconsistencies. Include -1 = 255 check in cov_address_get().
* Add some guards for BACAPP_LIGHTING_COMMAND to avoid errors/warnings.
* RPM test fixes
* Address requested changes. (#38)
This commit is contained in:
committed by
Steve Karg
parent
76abcaedd1
commit
f8ce70470c
@@ -564,7 +564,8 @@ typedef enum {
|
||||
EVENT_STATE_FAULT = 1,
|
||||
EVENT_STATE_OFFNORMAL = 2,
|
||||
EVENT_STATE_HIGH_LIMIT = 3,
|
||||
EVENT_STATE_LOW_LIMIT = 4
|
||||
EVENT_STATE_LOW_LIMIT = 4,
|
||||
EVENT_STATE_MAX = 5
|
||||
} BACNET_EVENT_STATE;
|
||||
|
||||
typedef enum {
|
||||
@@ -1165,7 +1166,8 @@ typedef enum {
|
||||
typedef enum {
|
||||
NOTIFY_ALARM = 0,
|
||||
NOTIFY_EVENT = 1,
|
||||
NOTIFY_ACK_NOTIFICATION = 2
|
||||
NOTIFY_ACK_NOTIFICATION = 2,
|
||||
NOTIFY_MAX = 3
|
||||
} BACNET_NOTIFY_TYPE;
|
||||
|
||||
typedef enum {
|
||||
@@ -1239,7 +1241,8 @@ typedef enum {
|
||||
which is used to store decoding */
|
||||
OBJECT_PROPRIETARY_MIN = 128,
|
||||
OBJECT_PROPRIETARY_MAX = 1023,
|
||||
MAX_BACNET_OBJECT_TYPE = 1024
|
||||
MAX_BACNET_OBJECT_TYPE = 1024,
|
||||
OBJECT_NONE = 0xFFFFu
|
||||
} BACNET_OBJECT_TYPE;
|
||||
|
||||
typedef enum {
|
||||
@@ -2090,7 +2093,8 @@ typedef enum {
|
||||
ACCESS_AUTHENTICATION_FACTOR_DISABLE_DISABLED_LOST = 2,
|
||||
ACCESS_AUTHENTICATION_FACTOR_DISABLE_DISABLED_STOLEN = 3,
|
||||
ACCESS_AUTHENTICATION_FACTOR_DISABLE_DISABLED_DAMAGED = 4,
|
||||
ACCESS_AUTHENTICATION_FACTOR_DISABLE_DISABLED_DESTROYED = 5
|
||||
ACCESS_AUTHENTICATION_FACTOR_DISABLE_DISABLED_DESTROYED = 5,
|
||||
ACCESS_AUTHENTICATION_FACTOR_DISABLE_MAX = 6
|
||||
} BACNET_ACCESS_AUTHENTICATION_FACTOR_DISABLE;
|
||||
|
||||
/* Authorization Exemption */
|
||||
|
||||
Reference in New Issue
Block a user