Fix (most) compilation warnings in Intel C++ Compiler (#38)

* Use BACNET_OBJECT_TYPE for all object type variables.

* Fix ICC "mixing enumerated type" warnings for assignments and parameters.

* Network Port: Use enums for state structs and remove erroneous bounds checks copy-pasted from IP_Subnet_Prefix setter.

* Fix ICC "unreachable statement" warnings.

* Fix ICC "unused variable" warnings when printing is disabled.

* Fix ICC "mixing enumerated type" warnings for struct initializers { 0 } by ensuring the first member is an integer type.

* Send_GetEvent_Global: Return 0 (invalid TSM invoke ID) instead of -1 = 255 (technically valid invoke ID) on failure.

* Fix ICC "pointless comparison" warnings.

* Fix wrong import in objects.c (memset being used).

* Fix signedness warnings and inconsistencies. Include -1 = 255 check in cov_address_get().

* Add some guards for BACAPP_LIGHTING_COMMAND to avoid errors/warnings.

* RPM test fixes

* Address requested changes. (#38)

ports/bdk-atxx4-mstp/bname.c

@@ -94,7 +94,7 @@ bool bacnet_name_set(
 
 bool bacnet_name_write_unique(
     uint16_t offset,
-    int object_type,
+    BACNET_OBJECT_TYPE object_type,
     uint32_t object_instance,
     BACNET_CHARACTER_STRING * char_string,
     BACNET_ERROR_CLASS * error_class,
@@ -103,7 +103,7 @@ bool bacnet_name_write_unique(
     bool status = false;
     size_t length = 0;
     uint8_t encoding = 0;
-    int duplicate_type = 0;
+    BACNET_OBJECT_TYPE duplicate_type = OBJECT_NONE;
     uint32_t duplicate_instance = 0;
 
     length = characterstring_length(char_string);

ports/bdk-atxx4-mstp/bname.h

@@ -48,7 +48,7 @@ extern "C" {
         char *default_string);
     bool bacnet_name_write_unique(
         uint16_t offset,
-        int object_type,
+        BACNET_OBJECT_TYPE object_type,
         uint32_t object_instance,
         BACNET_CHARACTER_STRING * char_string,
         BACNET_ERROR_CLASS * error_class,

ports/bdk-atxx4-mstp/device.c

@@ -484,7 +484,7 @@ unsigned Device_Object_List_Count(
 
 bool Device_Object_List_Identifier(
     uint32_t array_index,
-    int *object_type,
+    BACNET_OBJECT_TYPE *object_type,
     uint32_t * instance)
 {
     bool status = false;
@@ -518,11 +518,11 @@ bool Device_Object_List_Identifier(
 
 bool Device_Valid_Object_Name(
     BACNET_CHARACTER_STRING * object_name1,
-    int *object_type,
+    BACNET_OBJECT_TYPE *object_type,
     uint32_t * object_instance)
 {
     bool found = false;
-    int type = 0;
+    BACNET_OBJECT_TYPE type = OBJECT_NONE;
     uint32_t instance;
     uint32_t max_objects = 0, i = 0;
     bool check_id = false;
@@ -553,7 +553,7 @@ bool Device_Valid_Object_Name(
 }
 
 bool Device_Valid_Object_Id(
-    int object_type,
+    BACNET_OBJECT_TYPE object_type,
     uint32_t object_instance)
 {
     bool status = false;        /* return value */
@@ -592,7 +592,7 @@ int Device_Read_Property_Local(
     BACNET_BIT_STRING bit_string = { 0 };
     BACNET_CHARACTER_STRING char_string = { 0 };
     uint32_t i = 0;
-    int object_type = 0;
+    BACNET_OBJECT_TYPE object_type = OBJECT_NONE;
     uint32_t instance = 0;
     uint32_t count = 0;
     uint8_t *apdu = NULL;