Fix (most) compilation warnings in Intel C++ Compiler (#38)

* Use BACNET_OBJECT_TYPE for all object type variables.

* Fix ICC "mixing enumerated type" warnings for assignments and parameters.

* Network Port: Use enums for state structs and remove erroneous bounds checks copy-pasted from IP_Subnet_Prefix setter.

* Fix ICC "unreachable statement" warnings.

* Fix ICC "unused variable" warnings when printing is disabled.

* Fix ICC "mixing enumerated type" warnings for struct initializers { 0 } by ensuring the first member is an integer type.

* Send_GetEvent_Global: Return 0 (invalid TSM invoke ID) instead of -1 = 255 (technically valid invoke ID) on failure.

* Fix ICC "pointless comparison" warnings.

* Fix wrong import in objects.c (memset being used).

* Fix signedness warnings and inconsistencies. Include -1 = 255 check in cov_address_get().

* Add some guards for BACAPP_LIGHTING_COMMAND to avoid errors/warnings.

* RPM test fixes

* Address requested changes. (#38)

ports/atmega168/device.c

@@ -116,7 +116,7 @@ unsigned Device_Object_List_Count(
 
 bool Device_Object_List_Identifier(
     uint32_t array_index,
-    int *object_type,
+    BACNET_OBJECT_TYPE *object_type,
     uint32_t * instance)
 {
     bool status = false;
@@ -172,7 +172,7 @@ int Device_Read_Property(
     BACNET_BIT_STRING bit_string;
     BACNET_CHARACTER_STRING char_string;
     uint32_t i = 0;
-    int object_type = 0;
+    BACNET_OBJECT_TYPE object_type = OBJECT_NONE;
     uint32_t instance = 0;
     uint32_t count = 0;
 

ports/atmega168/device.h

@@ -81,7 +81,7 @@ extern "C" {
         void);
     bool Device_Object_List_Identifier(
         uint32_t array_index,
-        int *object_type,
+        BACNET_OBJECT_TYPE *object_type,
         uint32_t * instance);
 
     BACNET_DEVICE_STATUS Device_System_Status(
@@ -143,10 +143,10 @@ extern "C" {
 
     bool Device_Valid_Object_Name(
         const char *object_name,
-        int *object_type,
+        BACNET_OBJECT_TYPE *object_type,
         uint32_t * object_instance);
     char *Device_Valid_Object_Id(
-        int object_type,
+        BACNET_OBJECT_TYPE object_type,
         uint32_t object_instance);
 
     int Device_Encode_Property_APDU(