dali/bacnet_stack
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Run clang-format and enable CI check for it (#755)

Browse Source 
* pre-commit: Update and enable clang-format check

There is newer version from clang-format so use that. We do not yet want
18 as that is little bit too new.

* Format some thing by hand which clang-format "breaks"

Clang-format will format some things little bit off in some cases.
Format some things by hand so we get cleaner end result.

* Run clang-format with

```
pre-commit run --all-files clang-format
```

We have already in previously checked places where clang-format does not
make good format and ignored those (hopefully most of the things).

---------

Co-authored-by: Kari Argillander <kari.argillander@fidelix.com>
This commit is contained in:
Kari Argillander
2024-08-30 19:20:58 +03:00
committed by GitHub
parent 622a9e609e
commit f806c5829b
547 changed files with 18286 additions and 16575 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test/bacnet/rpm/src/main.c
+20 -10
View File
@@ -28,20 +28,25 @@ static int rpm_ack_decode_apdu(
{
int offset = 0;
if (!apdu)
if (!apdu) {
return -1;
}
/* optional checking - most likely was already done prior to this call */
if (apdu[0] != PDU_TYPE_COMPLEX_ACK)
if (apdu[0] != PDU_TYPE_COMPLEX_ACK) {
return -1;
}
*invoke_id = apdu[1];
if (apdu[2] != SERVICE_CONFIRMED_READ_PROP_MULTIPLE)
if (apdu[2] != SERVICE_CONFIRMED_READ_PROP_MULTIPLE) {
return -1;
}
offset = 3;
if (apdu_len > offset) {
if (service_request)
if (service_request) {
*service_request = &apdu[offset];
if (service_request_len)
}
if (service_request_len) {
*service_request_len = apdu_len - offset;
}
}
return offset;
@@ -56,22 +61,27 @@ static int rpm_decode_apdu(
{
unsigned offset = 0;
if (!apdu)
if (!apdu) {
return -1;
}
/* optional checking - most likely was already done prior to this call */
if (apdu[0] != PDU_TYPE_CONFIRMED_SERVICE_REQUEST)
if (apdu[0] != PDU_TYPE_CONFIRMED_SERVICE_REQUEST) {
return -1;
}
/* apdu[1] = encode_max_segs_max_apdu(0, MAX_APDU); */
*invoke_id = apdu[2]; /* invoke id - filled in by net layer */
if (apdu[3] != SERVICE_CONFIRMED_READ_PROP_MULTIPLE)
if (apdu[3] != SERVICE_CONFIRMED_READ_PROP_MULTIPLE) {
return -1;
}
offset = 4;
if (apdu_len > offset) {
if (service_request)
if (service_request) {
*service_request = &apdu[offset];
if (service_request_len)
}
if (service_request_len) {
*service_request_len = apdu_len - offset;
}
}
return offset;