dali/bacnet_stack
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Run clang-format and enable CI check for it (#755)

Browse Source 
* pre-commit: Update and enable clang-format check

There is newer version from clang-format so use that. We do not yet want
18 as that is little bit too new.

* Format some thing by hand which clang-format "breaks"

Clang-format will format some things little bit off in some cases.
Format some things by hand so we get cleaner end result.

* Run clang-format with

```
pre-commit run --all-files clang-format
```

We have already in previously checked places where clang-format does not
make good format and ignored those (hopefully most of the things).

---------

Co-authored-by: Kari Argillander <kari.argillander@fidelix.com>
This commit is contained in:
Kari Argillander
2024-08-30 19:20:58 +03:00
committed by GitHub
parent 622a9e609e
commit f806c5829b
547 changed files with 18286 additions and 16575 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test/bacnet/cov/src/main.c
+25 -15
View File
@@ -33,12 +33,14 @@ int ccov_notify_decode_apdu(
return -1;
}
/* optional checking - most likely was already done prior to this call */
if (apdu[0] != PDU_TYPE_CONFIRMED_SERVICE_REQUEST)
if (apdu[0] != PDU_TYPE_CONFIRMED_SERVICE_REQUEST) {
return -2;
}
/* apdu[1] = encode_max_segs_max_apdu(0, MAX_APDU); */
*invoke_id = apdu[2]; /* invoke id - filled in by net layer */
if (apdu[3] != SERVICE_CONFIRMED_COV_NOTIFICATION)
if (apdu[3] != SERVICE_CONFIRMED_COV_NOTIFICATION) {
return -3;
}
offset = 4;
/* optional limits - must be used as a pair */
@@ -56,13 +58,16 @@ int ucov_notify_decode_apdu(
int len = 0;
unsigned offset = 0;
if (!apdu)
if (!apdu) {
return -1;
}
/* optional checking - most likely was already done prior to this call */
if (apdu[0] != PDU_TYPE_UNCONFIRMED_SERVICE_REQUEST)
if (apdu[0] != PDU_TYPE_UNCONFIRMED_SERVICE_REQUEST) {
return -2;
if (apdu[1] != SERVICE_UNCONFIRMED_COV_NOTIFICATION)
}
if (apdu[1] != SERVICE_UNCONFIRMED_COV_NOTIFICATION) {
return -3;
}
/* optional limits - must be used as a pair */
offset = 2;
if (apdu_len > offset) {
@@ -82,15 +87,18 @@ static int cov_subscribe_decode_apdu(
int len = 0;
unsigned offset = 0;
if (!apdu)
if (!apdu) {
return -1;
}
/* optional checking - most likely was already done prior to this call */
if (apdu[0] != PDU_TYPE_CONFIRMED_SERVICE_REQUEST)
if (apdu[0] != PDU_TYPE_CONFIRMED_SERVICE_REQUEST) {
return -2;
}
/* apdu[1] = encode_max_segs_max_apdu(0, MAX_APDU); */
*invoke_id = apdu[2]; /* invoke id - filled in by net layer */
if (apdu[3] != SERVICE_CONFIRMED_SUBSCRIBE_COV)
if (apdu[3] != SERVICE_CONFIRMED_SUBSCRIBE_COV) {
return -3;
}
offset = 4;
/* optional limits - must be used as a pair */
@@ -111,15 +119,18 @@ static int cov_subscribe_property_decode_apdu(
int len = 0;
unsigned offset = 0;
if (!apdu)
if (!apdu) {
return -1;
}
/* optional checking - most likely was already done prior to this call */
if (apdu[0] != PDU_TYPE_CONFIRMED_SERVICE_REQUEST)
if (apdu[0] != PDU_TYPE_CONFIRMED_SERVICE_REQUEST) {
return -2;
}
/* apdu[1] = encode_max_segs_max_apdu(0, MAX_APDU); */
*invoke_id = apdu[2]; /* invoke id - filled in by net layer */
if (apdu[3] != SERVICE_CONFIRMED_SUBSCRIBE_COV_PROPERTY)
if (apdu[3] != SERVICE_CONFIRMED_SUBSCRIBE_COV_PROPERTY) {
return -3;
}
offset = 4;
/* optional limits - must be used as a pair */
@@ -132,8 +143,8 @@ static int cov_subscribe_property_decode_apdu(
}
/* dummy function stubs */
static void testCOVNotifyData(
const BACNET_COV_DATA *data, BACNET_COV_DATA *test_data)
static void
testCOVNotifyData(const BACNET_COV_DATA *data, BACNET_COV_DATA *test_data)
{
const BACNET_PROPERTY_VALUE *value = NULL;
BACNET_PROPERTY_VALUE *test_value = NULL;
@@ -295,8 +306,7 @@ static void testCOVSubscribePropertyData(
}
}
static void
testCOVSubscribeEncoding(
static void testCOVSubscribeEncoding(
uint8_t invoke_id, const BACNET_SUBSCRIBE_COV_DATA *data)
{
uint8_t apdu[480] = { 0 };