Run clang-format and enable CI check for it (#755)

* pre-commit: Update and enable clang-format check

There is newer version from clang-format so use that. We do not yet want
18 as that is little bit too new.

* Format some thing by hand which clang-format "breaks"

Clang-format will format some things little bit off in some cases.
Format some things by hand so we get cleaner end result.

* Run clang-format with

```
pre-commit run --all-files clang-format
```

We have already in previously checked places where clang-format does not
make good format and ignored those (hopefully most of the things).

---------

Co-authored-by: Kari Argillander <kari.argillander@fidelix.com>
This commit is contained in:
Kari Argillander
2024-08-30 19:20:58 +03:00
committed by GitHub
parent 622a9e609e
commit f806c5829b
547 changed files with 18286 additions and 16575 deletions
+21 -19
View File
@@ -18,16 +18,16 @@
* @param lastReceivedObjectIdentifier Object identifier
* @return Bytes encoded.
*/
int getevent_apdu_encode(uint8_t *apdu,
const BACNET_OBJECT_ID *lastReceivedObjectIdentifier)
int getevent_apdu_encode(
uint8_t *apdu, const BACNET_OBJECT_ID *lastReceivedObjectIdentifier)
{
int len = 0;
int apdu_len = 0;
/* encode optional parameter */
if (lastReceivedObjectIdentifier) {
len = encode_context_object_id(apdu, 0,
lastReceivedObjectIdentifier->type,
len = encode_context_object_id(
apdu, 0, lastReceivedObjectIdentifier->type,
lastReceivedObjectIdentifier->instance);
apdu_len += len;
}
@@ -43,8 +43,7 @@ int getevent_apdu_encode(uint8_t *apdu,
* @return number of bytes encoded, or zero if unable to encode or too large
*/
size_t getevent_service_request_encode(
uint8_t *apdu, size_t apdu_size,
const BACNET_OBJECT_ID *data)
uint8_t *apdu, size_t apdu_size, const BACNET_OBJECT_ID *data)
{
size_t apdu_len = 0; /* total length of the apdu, return value */
@@ -67,9 +66,8 @@ size_t getevent_service_request_encode(
* @return Bytes encoded.
* @deprecated Use getevent_apdu_encode() instead
*/
int getevent_encode_apdu(uint8_t *apdu,
uint8_t invoke_id,
const BACNET_OBJECT_ID *data)
int getevent_encode_apdu(
uint8_t *apdu, uint8_t invoke_id, const BACNET_OBJECT_ID *data)
{
int len = 0; /* length of each encoding */
int apdu_len = 0; /* total length of the apdu, return value */
@@ -99,7 +97,8 @@ int getevent_encode_apdu(uint8_t *apdu,
*
* @return Bytes encoded.
*/
int getevent_decode_service_request(const uint8_t *apdu,
int getevent_decode_service_request(
const uint8_t *apdu,
unsigned apdu_len,
BACNET_OBJECT_ID *lastReceivedObjectIdentifier)
{
@@ -112,8 +111,8 @@ int getevent_decode_service_request(const uint8_t *apdu,
return -1;
}
if (len < apdu_len) {
len += decode_object_id(&apdu[len],
&lastReceivedObjectIdentifier->type,
len += decode_object_id(
&apdu[len], &lastReceivedObjectIdentifier->type,
&lastReceivedObjectIdentifier->instance);
}
}
@@ -139,7 +138,8 @@ int getevent_ack_encode_apdu_init(
return apdu_len;
}
int getevent_ack_encode_apdu_data(uint8_t *apdu,
int getevent_ack_encode_apdu_data(
uint8_t *apdu,
size_t max_apdu,
BACNET_GET_EVENT_INFORMATION_DATA *get_event_data)
{
@@ -152,8 +152,8 @@ int getevent_ack_encode_apdu_data(uint8_t *apdu,
event_data = get_event_data;
while (event_data) {
/* Tag 0: objectIdentifier */
apdu_len += encode_context_object_id(&apdu[apdu_len], 0,
event_data->objectIdentifier.type,
apdu_len += encode_context_object_id(
&apdu[apdu_len], 0, event_data->objectIdentifier.type,
event_data->objectIdentifier.instance);
/* Tag 1: eventState */
apdu_len += encode_context_enumerated(
@@ -202,7 +202,8 @@ int getevent_ack_encode_apdu_end(
return apdu_len;
}
int getevent_ack_decode_service_request(const uint8_t *apdu,
int getevent_ack_decode_service_request(
const uint8_t *apdu,
int apdu_len, /* total length of the apdu */
BACNET_GET_EVENT_INFORMATION_DATA *get_event_data,
bool *moreEvents)
@@ -227,8 +228,8 @@ int getevent_ack_decode_service_request(const uint8_t *apdu,
if (decode_is_context_tag(&apdu[len], 0)) {
len += decode_tag_number_and_value(
&apdu[len], &tag_number, &len_value);
len += decode_object_id(&apdu[len],
&event_data->objectIdentifier.type,
len += decode_object_id(
&apdu[len], &event_data->objectIdentifier.type,
&event_data->objectIdentifier.instance);
} else {
return -1;
@@ -250,7 +251,8 @@ int getevent_ack_decode_service_request(const uint8_t *apdu,
if (decode_is_context_tag(&apdu[len], 2)) {
len += decode_tag_number_and_value(
&apdu[len], &tag_number, &len_value);
len += decode_bitstring(&apdu[len], len_value,
len += decode_bitstring(
&apdu[len], len_value,
&event_data->acknowledgedTransitions);
} else {
return -1;