Bugfix/deprecate decode tag number and value (#481)
* added or updated secure the BACnet primitive value decoders - the core codecs - named bacnet_x_decode(), bacnet_x_application_decode() and bacnet_x_context_decode where x is one of the 13 BACnet primitive value names. The updated API includes an APDU size to prevent over-reading of an APDU buffer while decoding. Improved or added unit test code coverage for the BACnet primitive value decoders. * marked the insecure decoding API as 'deprecated' which is defined in src/bacnet/basic/sys/platform.h and can be disabled during a build. * added secure decoders for BACnetTimeValue, BACnetHostNPort, BACnetTimeStamp, BACnetAddress, and Weekly_Schedule and improved unit test code coverage. * improved test code coverage for BACnet objects and properties. * secured AtomicReadFile and AtomicWriteFile service decoders and improved unit test code coverage. * secured BACnet Error service decoder and improved unit test code coverage. --------- Co-authored-by: Steve Karg <skarg@users.sourceforge.net>
This commit is contained in:
@@ -461,7 +461,7 @@ static void test_bacerror_decode_error_class_and_code(void)
|
||||
|
||||
.expected_call_history =
|
||||
(void *[]) {
|
||||
decode_tag_number_and_value, NULL, /* mark end of array */
|
||||
bacnet_enumerated_application_decode, NULL, /* mark end of array */
|
||||
},
|
||||
|
||||
.decode_tag_number_and_value_custom_fake_contexts_len = 2,
|
||||
|
||||
Reference in New Issue
Block a user