Bugfix/deprecate decode tag number and value (#481)

* added or updated secure the BACnet primitive value decoders - the core codecs - named bacnet_x_decode(), bacnet_x_application_decode() and bacnet_x_context_decode where x is one of the 13 BACnet primitive value names.  The updated API includes an APDU size to prevent over-reading of an APDU buffer while decoding.  Improved or added unit test code coverage for the BACnet primitive value decoders.

* marked the insecure decoding API as 'deprecated' which is defined in src/bacnet/basic/sys/platform.h and can be disabled during a build. 

* added secure decoders for BACnetTimeValue, BACnetHostNPort, BACnetTimeStamp, BACnetAddress, and Weekly_Schedule and improved unit test code coverage.

* improved test code coverage for BACnet objects and properties.

* secured AtomicReadFile and AtomicWriteFile service decoders and improved unit test code coverage.

* secured BACnet Error service decoder and improved unit test code coverage.

---------

Co-authored-by: Steve Karg <skarg@users.sourceforge.net>
This commit is contained in:
Steve Karg
2023-09-08 11:39:27 -05:00
committed by GitHub
parent bc8c261153
commit f641aacddb
67 changed files with 6103 additions and 3145 deletions
+7 -1
View File
@@ -37,7 +37,7 @@ ifeq (${JOBS},)
JOBS = "-j %NUMBER_OF_PROCESSORS%"
endif
ifeq ($(UNAME_S),Linux)
JOBS = "-j $(nproc)"
JOBS = "-j $(shell nproc)"
endif
ifeq ($(UNAME_S),Darwin)
JOBS = "-j $(sysctl -n hw.ncpu)"
@@ -68,11 +68,17 @@ retest:
report:
[ -d $(BUILD_DIR) ] && cat $(BUILD_DIR)/Testing/Temporary/LastTest*.log
.PHONY: rebuild
rebuild:
[ -d $(BUILD_DIR) ] && cd $(BUILD_DIR) && cmake --build . --clean-first && cd ..
.PHONY: env
env:
@echo "Makefile environment variables"
@echo "UNAME_S=$(UNAME_S)"
@echo "JOBS=$(JOBS)"
@echo "MAKEFLAGS=$(MAKEFLAGS)"
@echo "CTEST_OPTIONS=$(CTEST_OPTIONS)"
@echo "BUILD_DIR=$(BUILD_DIR)"
.PHONY: clean