Bugfix/deprecate decode tag number and value (#481)
* added or updated secure the BACnet primitive value decoders - the core codecs - named bacnet_x_decode(), bacnet_x_application_decode() and bacnet_x_context_decode where x is one of the 13 BACnet primitive value names. The updated API includes an APDU size to prevent over-reading of an APDU buffer while decoding. Improved or added unit test code coverage for the BACnet primitive value decoders. * marked the insecure decoding API as 'deprecated' which is defined in src/bacnet/basic/sys/platform.h and can be disabled during a build. * added secure decoders for BACnetTimeValue, BACnetHostNPort, BACnetTimeStamp, BACnetAddress, and Weekly_Schedule and improved unit test code coverage. * improved test code coverage for BACnet objects and properties. * secured AtomicReadFile and AtomicWriteFile service decoders and improved unit test code coverage. * secured BACnet Error service decoder and improved unit test code coverage. --------- Co-authored-by: Steve Karg <skarg@users.sourceforge.net>
This commit is contained in:
+12
-1
@@ -7,6 +7,12 @@ project(Unit_Tests)
|
||||
# add definitions
|
||||
add_definitions(-fprofile-arcs -ftest-coverage)
|
||||
|
||||
option(BACNET_STACK_DEPRECATED_DISABLE "Disable deprecation compile warnings" ON)
|
||||
|
||||
if(BACNET_STACK_DEPRECATED_DISABLE)
|
||||
add_definitions(-DBACNET_STACK_DEPRECATED_DISABLE)
|
||||
endif()
|
||||
|
||||
# Set the compiler options
|
||||
if (NOT MSVC)
|
||||
add_compile_options(-Wall -g -O0 -W -fprofile-arcs -ftest-coverage)
|
||||
@@ -33,7 +39,7 @@ add_custom_command(TARGET lcov
|
||||
#
|
||||
|
||||
list(APPEND testdirs
|
||||
unit/bacnet/bacerror
|
||||
# unit/bacnet/bacerror
|
||||
unit/bacnet/bits
|
||||
)
|
||||
|
||||
@@ -60,6 +66,7 @@ list(APPEND testdirs
|
||||
bacnet/event
|
||||
bacnet/getalarm
|
||||
bacnet/getevent
|
||||
bacnet/hostnport
|
||||
bacnet/iam
|
||||
bacnet/ihave
|
||||
bacnet/indtext
|
||||
@@ -102,11 +109,14 @@ list(APPEND testdirs
|
||||
bacnet/basic/object/bi
|
||||
bacnet/basic/object/bo
|
||||
bacnet/basic/object/bv
|
||||
bacnet/basic/object/channel
|
||||
bacnet/basic/object/color_object
|
||||
bacnet/basic/object/color_temperature
|
||||
bacnet/basic/object/command
|
||||
bacnet/basic/object/credential_data_input
|
||||
bacnet/basic/object/csv
|
||||
bacnet/basic/object/device
|
||||
bacnet/basic/object/iv
|
||||
#bacnet/basic/object/lc #Tests skipped, redesign to use only API
|
||||
bacnet/basic/object/lo
|
||||
bacnet/basic/object/lsp
|
||||
@@ -118,6 +128,7 @@ list(APPEND testdirs
|
||||
bacnet/basic/object/osv
|
||||
bacnet/basic/object/piv
|
||||
bacnet/basic/object/schedule
|
||||
bacnet/basic/object/trendlog
|
||||
# basic/sys
|
||||
bacnet/basic/sys/color_rgb
|
||||
bacnet/basic/sys/days
|
||||
|
||||
Reference in New Issue
Block a user