dali/bacnet_stack
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bugfix/deprecate decode tag number and value (#481)

Browse Source 
* added or updated secure the BACnet primitive value decoders - the core codecs - named bacnet_x_decode(), bacnet_x_application_decode() and bacnet_x_context_decode where x is one of the 13 BACnet primitive value names.  The updated API includes an APDU size to prevent over-reading of an APDU buffer while decoding.  Improved or added unit test code coverage for the BACnet primitive value decoders.

* marked the insecure decoding API as 'deprecated' which is defined in src/bacnet/basic/sys/platform.h and can be disabled during a build. 

* added secure decoders for BACnetTimeValue, BACnetHostNPort, BACnetTimeStamp, BACnetAddress, and Weekly_Schedule and improved unit test code coverage.

* improved test code coverage for BACnet objects and properties.

* secured AtomicReadFile and AtomicWriteFile service decoders and improved unit test code coverage.

* secured BACnet Error service decoder and improved unit test code coverage.

---------

Co-authored-by: Steve Karg <skarg@users.sourceforge.net>
This commit is contained in:
Steve Karg
2023-09-08 11:39:27 -05:00
committed by GitHub
parent bc8c261153
commit f641aacddb
67 changed files with 6103 additions and 3145 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/bacnet/timestamp.h
+20 -6
View File
@@ -25,6 +25,7 @@
#define _TIMESTAMP_H_
#include <stdint.h>
#include "bacnet/bacnet_stack_exports.h"
#include "bacnet/basic/sys/platform.h"
#include "bacnet/bacenum.h"
#include "bacnet/bacdcode.h"
@@ -73,17 +74,30 @@ extern "C" {
int bacapp_encode_timestamp(
uint8_t * apdu,
BACNET_TIMESTAMP * value);
BACNET_STACK_EXPORT
int bacapp_decode_timestamp(
uint8_t * apdu,
BACNET_TIMESTAMP * value);
BACNET_STACK_EXPORT
int bacapp_encode_context_timestamp(
uint8_t * apdu,
uint8_t tag_number,
BACNET_TIMESTAMP * value);
BACNET_STACK_EXPORT
int bacnet_timestamp_decode(
uint8_t * apdu,
uint32_t apdu_size,
BACNET_TIMESTAMP * value);
BACNET_STACK_EXPORT
int bacnet_timestamp_context_decode(
uint8_t * apdu,
uint32_t apdu_size,
uint8_t tag_number,
BACNET_TIMESTAMP * value);
BACNET_STACK_DEPRECATED("Use bacnet_timestamp_decode() instead")
BACNET_STACK_EXPORT
int bacapp_decode_timestamp(
uint8_t * apdu,
BACNET_TIMESTAMP * value);
BACNET_STACK_DEPRECATED("Use bacnet_timestamp_context_decode() instead")
BACNET_STACK_EXPORT
int bacapp_decode_context_timestamp(
uint8_t * apdu,