Bugfix/deprecate decode tag number and value (#481)

* added or updated secure the BACnet primitive value decoders - the core codecs - named bacnet_x_decode(), bacnet_x_application_decode() and bacnet_x_context_decode where x is one of the 13 BACnet primitive value names.  The updated API includes an APDU size to prevent over-reading of an APDU buffer while decoding.  Improved or added unit test code coverage for the BACnet primitive value decoders.

* marked the insecure decoding API as 'deprecated' which is defined in src/bacnet/basic/sys/platform.h and can be disabled during a build. 

* added secure decoders for BACnetTimeValue, BACnetHostNPort, BACnetTimeStamp, BACnetAddress, and Weekly_Schedule and improved unit test code coverage.

* improved test code coverage for BACnet objects and properties.

* secured AtomicReadFile and AtomicWriteFile service decoders and improved unit test code coverage.

* secured BACnet Error service decoder and improved unit test code coverage.

---------

Co-authored-by: Steve Karg <skarg@users.sourceforge.net>

This commit is contained in:

Steve Karg

2023-09-08 11:39:27 -05:00

committed by

GitHub

parent bc8c261153

commit f641aacddb

67 changed files with 6103 additions and 3145 deletions

									
										src/bacnet/hostnport.h
									
		+1
		-1
	
												View File
												
				@@ -56,7 +56,7 @@ extern "C" {

				        BACNET_HOST_N_PORT *address);

				    BACNET_STACK_EXPORT

				    int host_n_port_decode(uint8_t *apdu,

				        uint16_t apdu_len,

				        uint32_t apdu_len,

				        BACNET_ERROR_CODE *error_code,

				        BACNET_HOST_N_PORT *address);

				    BACNET_STACK_EXPORT