dali/bacnet_stack
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Added Send_I_Am_Broadcast() function to Who-Is handler so that other Send_I_Am() will honor DCC Disable-Initiatiation. (#918)

Browse Source
This commit is contained in:
Steve Karg
2025-02-26 17:01:53 -06:00
committed by GitHub
parent 849cbb238b
commit f61038ad6c
3 changed files with 25 additions and 29 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/bacnet/basic/service/s_iam.c
+20 -26
View File
@@ -91,29 +91,17 @@ int iam_encode_pdu(
return pdu_len;
}
/** Broadcast an I Am message.
* @ingroup DMDDB
*
/**
* @brief Send an I-Am broadcast message in response to Who-Is message
* @param buffer [in] The buffer to use for building and sending the message.
*/
void Send_I_Am(uint8_t *buffer)
void Send_I_Am_Broadcast(uint8_t *buffer)
{
int pdu_len = 0;
BACNET_ADDRESS dest;
int bytes_sent = 0;
BACNET_NPDU_DATA npdu_data;
#if 0
/* note: there is discussion in the BACnet committee
that we should allow a device to reply with I-Am
so that dynamic binding always work. If the DCC
initiator loses the MAC address and routing info,
they can never re-enable DCC because they can't
find the device with WhoIs/I-Am */
/* are we are forbidden to send? */
if (!dcc_communication_enabled())
return 0;
#endif
/* encode the data */
pdu_len = iam_encode_pdu(buffer, &dest, &npdu_data);
/* send data */
@@ -123,6 +111,23 @@ void Send_I_Am(uint8_t *buffer)
}
}
/**
* @brief Send an I-Am broadcast message NOT in response to Who-Is message
* @param buffer [in] The buffer to use for building and sending the message.
*/
void Send_I_Am(uint8_t *buffer)
{
/* This function is sending a broadcast I-Am
that is not in response to a Who-Is.
This is common at device power up. */
if (dcc_communication_initiation_disabled()) {
/* we are forbidden to send */
debug_print("I-Am: Communication Disabled!\n");
return;
}
Send_I_Am_Broadcast(buffer);
}
/** Encode an I Am message to be unicast directly back to the src.
*
* @param buffer [in,out] The buffer to use for building the message.
@@ -177,17 +182,6 @@ void Send_I_Am_Unicast(uint8_t *buffer, const BACNET_ADDRESS *src)
int bytes_sent = 0;
BACNET_NPDU_DATA npdu_data;
#if 0
/* note: there is discussion in the BACnet committee
that we should allow a device to reply with I-Am
so that dynamic binding always work. If the DCC
initiator loses the MAC address and routing info,
they can never re-enable DCC because they can't
find the device with WhoIs/I-Am */
/* are we are forbidden to send? */
if (!dcc_communication_enabled())
return 0;
#endif
/* encode the data */
pdu_len = iam_unicast_encode_pdu(buffer, src, &dest, &npdu_data);
/* send data */