Require bacdef.h as first bacnet header to include (#598) (#600)

* Require bacdeps.h as first bacnet header to include

BACnet headers need to pull in optional configuration and
optional ecosystem overrides to allow integrators to control
builds.  This commit changes bacnet header files to first
include bacnet/bacdep.h to consistently introduce integrator
header files.

Verified by:

1. make clean all test

2. ./zephyr/scripts/twister -p unit_testing \
        -T bacnet-stack/zephyr/tests/



* Migrate BACNET_UNSIGNED_INTEGER defn to bacdef.h

Verified by:

1. make clean all test

2. ./zephyr/scripts/twister -p unit_testing \
        -T bacnet-stack/zephyr/tests/



---------

Signed-off-by: Gregory Shue <gregory.shue@legrand.com>
Co-authored-by: Greg Shue <32416235+gregshue@users.noreply.github.com>
Co-authored-by: Gregory Shue <gregory.shue@legrand.com>

src/bacnet/datalink/arcnet.h

@@ -27,8 +27,8 @@
 #include <stdbool.h>
 #include <stdint.h>
 #include <stddef.h>
+#include "bacnet/bacdef.h"  /* Must be before all other bacnet *.h files */
 #include "bacnet/bacnet_stack_exports.h"
-#include "bacnet/bacdef.h"
 #include "bacnet/npdu.h"
 
 /* specific defines for ARCNET */

src/bacnet/datalink/automac.h

@@ -29,6 +29,7 @@
 #include <stdint.h>
 #include <stdlib.h>
 #include <stdio.h>
+#include "bacnet/bacdef.h"  /* Must be before all other bacnet *.h files */
 
 /* MS/TP Auto MAC address functionality */
 /* starting number available for AutoMAC */

src/bacnet/datalink/bacsec.h

@@ -39,8 +39,8 @@
 #include <stdbool.h>
 #include <stdint.h>
 
+#include "bacnet/bacdef.h"  /* Must be before all other bacnet *.h files */
 #include "bacnet/bacnet_stack_exports.h"
-#include "bacnet/bacdef.h"
 #include "bacnet/bacenum.h"
 
 typedef struct BACnet_Security_Wrapper {

src/bacnet/datalink/bip.h

@@ -27,8 +27,8 @@
 #include <stdbool.h>
 #include <stdint.h>
 #include <stddef.h>
+#include "bacnet/bacdef.h"  /* Must be before all other bacnet *.h files */
 #include "bacnet/bacnet_stack_exports.h"
-#include "bacnet/bacdef.h"
 #include "bacnet/npdu.h"
 #include "bacnet/datalink/bvlc.h"
 

src/bacnet/datalink/bip6.h

@@ -16,8 +16,8 @@
 #include <stdbool.h>
 #include <stdint.h>
 #include <stddef.h>
+#include "bacnet/bacdef.h"  /* Must be before all other bacnet *.h files */
 #include "bacnet/bacnet_stack_exports.h"
-#include "bacnet/bacdef.h"
 #include "bacnet/npdu.h"
 #include "bacnet/datalink/bvlc6.h"
 

src/bacnet/datalink/bvlc.h

@@ -27,7 +27,7 @@
 #include <stdbool.h>
 #include <stdint.h>
 #include <stddef.h>
-#include "bacnet/bacdef.h"
+#include "bacnet/bacdef.h"  /* Must be before all other bacnet *.h files */
 #include "bacnet/npdu.h"
 
 /**

src/bacnet/datalink/bvlc6.h

@@ -12,8 +12,8 @@
 #include <stdbool.h>
 #include <stdint.h>
 #include <stddef.h>
+#include "bacnet/bacdef.h"  /* Must be before all other bacnet *.h files */
 #include "bacnet/bacnet_stack_exports.h"
-#include "bacnet/bacdef.h"
 #include "bacnet/npdu.h"
 
 /**

src/bacnet/datalink/cobs.h

@@ -26,6 +26,7 @@
 
 #include <stddef.h>
 #include <stdint.h>
+#include "bacnet/bacdef.h"  /* Must be before all other bacnet *.h files */
 #include "bacnet/bacnet_stack_exports.h"
 
 /* number of bytes needed for COBS encoded CRC */

src/bacnet/datalink/crc.h

@@ -26,6 +26,7 @@
 
 #include <stddef.h>
 #include <stdint.h>
+#include "bacnet/bacdef.h"  /* Must be before all other bacnet *.h files */
 #include "bacnet/bacnet_stack_exports.h"
 
 #ifdef __cplusplus

src/bacnet/datalink/datalink.h

@@ -24,9 +24,9 @@
 #ifndef DATALINK_H
 #define DATALINK_H
 
+#include "bacnet/bacdef.h"  /* Must be before all other bacnet *.h files */
 #include "bacnet/bacnet_stack_exports.h"
 #include "bacnet/config.h"
-#include "bacnet/bacdef.h"
 
 #if defined(BACDL_ETHERNET)
 #include "bacnet/datalink/ethernet.h"

src/bacnet/datalink/dlenv.h

@@ -27,6 +27,7 @@
 #include <stddef.h>
 #include <stdint.h>
 #include <stdint.h>
+#include "bacnet/bacdef.h"  /* Must be before all other bacnet *.h files */
 #include "bacnet/datalink/bvlc.h"
 
 #include "bacnet/bacnet_stack_exports.h"

src/bacnet/datalink/dlmstp.h

@@ -27,10 +27,10 @@
 #include <stddef.h>
 #include <stdbool.h>
 #include <stdint.h>
+#include "bacnet/bacdef.h"  /* Must be before all other bacnet *.h files */
 #include "bacnet/bacnet_stack_exports.h"
 #include "bacnet/basic/sys/ringbuf.h"
 #include "bacnet/datalink/mstpdef.h"
-#include "bacnet/bacdef.h"
 #include "bacnet/npdu.h"
 
 /* defines specific to MS/TP */

src/bacnet/datalink/ethernet.h

@@ -27,8 +27,8 @@
 #include <stdbool.h>
 #include <stdint.h>
 #include <stddef.h>
+#include "bacnet/bacdef.h"  /* Must be before all other bacnet *.h files */
 #include "bacnet/bacnet_stack_exports.h"
-#include "bacnet/bacdef.h"
 #include "bacnet/npdu.h"
 
 /* specific defines for Ethernet */

src/bacnet/datalink/mstp.h

@@ -28,6 +28,7 @@
 #include <stddef.h>
 #include <stdint.h>
 #include <stdbool.h>
+#include "bacnet/bacdef.h"  /* Must be before all other bacnet *.h files */
 #include "bacnet/bacnet_stack_exports.h"
 #include "bacnet/datalink/mstpdef.h"
 #include "bacnet/config.h"

src/bacnet/datalink/mstpdef.h

@@ -27,7 +27,7 @@
 #include <stddef.h>
 #include <stdint.h>
 #include <stdbool.h>
-#include "bacnet/bacdef.h"
+#include "bacnet/bacdef.h"  /* Must be before all other bacnet *.h files */
 
 /*  The value 255 is used to denote broadcast when used as a */
 /* destination address but is not allowed as a value for a station. */

src/bacnet/datalink/mstptext.h

@@ -24,6 +24,7 @@
 #ifndef MSTPTEXT_H
 #define MSTPTEXT_H
 
+#include "bacnet/bacdef.h"  /* Must be before all other bacnet *.h files */
 #include "bacnet/bacnet_stack_exports.h"
 
 #ifdef __cplusplus