Renamed and fixed proprietary min-max range defines for reject and abort codes.

bacnet-stack/include/bacenum.h

@@ -1211,9 +1211,9 @@ typedef enum {
     SERVICE_SUPPORTED_UTC_TIME_SYNCHRONIZATION = 36,
     SERVICE_SUPPORTED_WHO_HAS = 33,
     SERVICE_SUPPORTED_WHO_IS = 34
-        /* Other services to be added as they are defined. */
+    /* Other services to be added as they are defined. */
-        /* All values in this production are reserved */
+    /* All values in this production are reserved */
-        /* for definition by ASHRAE. */
+    /* for definition by ASHRAE. */
 } BACNET_SERVICES_SUPPORTED;
 
 typedef enum {
@@ -1334,10 +1334,10 @@ typedef enum {
     /* Enumerated values 0-63 are reserved for definition by ASHRAE. */
     /* Enumerated values 64-65535 may be used by others subject to */
     /* the procedures and constraints described in Clause 23. */
-    MAX_BACNET_ABORT_REASON = 5
+    MAX_BACNET_ABORT_REASON = 5,
+    ABORT_REASON_PROPRIETARY_FIRST = 64,
+    ABORT_REASON_PROPRIETARY_LAST = 65535
 } BACNET_ABORT_REASON;
-#define FIRST_PROPRIETARY_ABORT_REASON 64
-#define LAST_PROPRIETARY_ABORT_REASON 65535
 
 typedef enum {
     REJECT_REASON_OTHER = 0,
@@ -1353,10 +1353,10 @@ typedef enum {
     /* Enumerated values 0-63 are reserved for definition by ASHRAE. */
     /* Enumerated values 64-65535 may be used by others subject to */
     /* the procedures and constraints described in Clause 23. */
-    MAX_BACNET_REJECT_REASON = 10
+    MAX_BACNET_REJECT_REASON = 10,
+    REJECT_REASON_PROPRIETARY_FIRST = 64,
+    REJECT_REASON_PROPRIETARY_LAST = 65535
 } BACNET_REJECT_REASON;
-#define FIRST_PROPRIETARY_REJECT_REASON 64
-#define LAST_PROPRIETARY_REJECT_REASON 65535
 
 typedef enum {
     ERROR_CLASS_DEVICE = 0,

bacnet-stack/src/abort.c

@@ -63,7 +63,7 @@ BACNET_ABORT_REASON abort_convert_error_code(
             abort_code = ABORT_REASON_SEGMENTATION_NOT_SUPPORTED;
             break;
         case ERROR_CODE_ABORT_PROPRIETARY:
-            abort_code = (BACNET_ABORT_REASON) FIRST_PROPRIETARY_ABORT_REASON;
+            abort_code = ABORT_REASON_PROPRIETARY_FIRST;
             break;
         case ERROR_CODE_ABORT_OTHER:
         default:

bacnet-stack/src/bactext.c

@@ -1483,6 +1483,8 @@ INDTEXT_DATA bacnet_reject_reason_names[] = {
     ,
     {REJECT_REASON_UNRECOGNIZED_SERVICE, "Unrecognized Service"}
     ,
+    {REJECT_REASON_PROPRIETARY_FIRST, "Proprietary"}
+    ,
     {0, NULL}
 };
 
@@ -1490,7 +1492,7 @@ const char *bactext_reject_reason_name(
     unsigned index)
 {
     return indtext_by_index_split_default(bacnet_reject_reason_names, index,
-        FIRST_PROPRIETARY_REJECT_REASON, ASHRAE_Reserved_String,
+        REJECT_REASON_PROPRIETARY_FIRST, ASHRAE_Reserved_String,
         Vendor_Proprietary_String);
 }
 
@@ -1506,6 +1508,8 @@ INDTEXT_DATA bacnet_abort_reason_names[] = {
     ,
     {ABORT_REASON_SEGMENTATION_NOT_SUPPORTED, "Segmentation Not Supported"}
     ,
+    {ABORT_REASON_PROPRIETARY_FIRST, "Proprietary"}
+    ,
     {0, NULL}
 };
 
@@ -1513,7 +1517,7 @@ const char *bactext_abort_reason_name(
     unsigned index)
 {
     return indtext_by_index_split_default(bacnet_abort_reason_names, index,
-        FIRST_PROPRIETARY_ABORT_REASON, ASHRAE_Reserved_String,
+        ABORT_REASON_PROPRIETARY_FIRST, ASHRAE_Reserved_String,
         Vendor_Proprietary_String);
 }
 

bacnet-stack/src/reject.c

@@ -80,8 +80,7 @@ BACNET_REJECT_REASON reject_convert_error_code(
             reject_code = REJECT_REASON_UNRECOGNIZED_SERVICE;
             break;
         case ERROR_CODE_REJECT_PROPRIETARY:
-            reject_code =
+            reject_code = REJECT_REASON_PROPRIETARY_FIRST;
-                (BACNET_REJECT_REASON) FIRST_PROPRIETARY_REJECT_REASON;
             break;
         case ERROR_CODE_REJECT_OTHER:
         default: