Build more code in CI (#725)

* bugfix/hostnport: Fix bacnet_fdt_entry_from_ascii() parse wrong
* apps/router: Fix Wstrict-prototypes compiler warnings
* apps/router: Fix -Wmissing-field-initializers compiler warning
* ports/linux: Fix -Wself-assign compiler warning
* ports/linux: Fix -Wunused-function compiler warning
* Fix -Wimplicit-function-declaration warnings
* ci: Add more compile options to enable more code build
* ci: Do not fail-fast our main matrix build
* cmake: Add -Wno-c99-extensions compiler option

---------

Co-authored-by: Kari Argillander <kari.argillander@fidelix.com>
Co-authored-by: Steve Karg <skarg@users.sourceforge.net>

apps/epics/main.c

@@ -38,6 +38,8 @@
 #include "bacnet/basic/sys/keylist.h"
 #include "bacnet/basic/tsm/tsm.h"
 #include "bacnet/datalink/datalink.h"
+#include "bacnet/datalink/bip.h"
+#include "bacnet/basic/bbmd/h_bbmd.h"
 #include "bacnet/datalink/dlenv.h"
 #include "bacepics.h"
 

apps/readbdt/main.c

@@ -24,6 +24,8 @@
 #include "bacnet/basic/object/device.h"
 #include "bacnet/datalink/datalink.h"
 #include "bacnet/datalink/bvlc.h"
+#include "bacnet/datalink/bip.h"
+#include "bacnet/basic/bbmd/h_bbmd.h"
 /* some demo stuff needed */
 #include "bacnet/basic/sys/debug.h"
 #include "bacnet/basic/sys/filename.h"

apps/readfdt/main.c

@@ -24,6 +24,8 @@
 #include "bacnet/basic/object/device.h"
 #include "bacnet/datalink/datalink.h"
 #include "bacnet/datalink/bvlc.h"
+#include "bacnet/datalink/bip.h"
+#include "bacnet/basic/bbmd/h_bbmd.h"
 /* some demo stuff needed */
 #include "bacnet/basic/sys/debug.h"
 #include "bacnet/basic/sys/filename.h"

apps/router/main.c

@@ -41,7 +41,7 @@ ROUTER_PORT *head = NULL; /* pointer to list of router ports */
 
 int port_count;
 
-void print_help();
+void print_help(void);
 
 bool read_config(char *filepath);
 
@@ -49,17 +49,17 @@ bool parse_cmd(int argc, char *argv[]);
 
 void init_port_threads(ROUTER_PORT *port_list);
 
-bool init_router();
+bool init_router(void);
 
-void cleanup();
+void cleanup(void);
 
 void print_msg(BACMSG *msg);
 
 uint16_t process_msg(BACMSG *msg, MSG_DATA *data, uint8_t **buff);
 
-uint16_t get_next_free_dnet();
+uint16_t get_next_free_dnet(void);
 
-int kbhit();
+int kbhit(void);
 
 inline bool is_network_msg(BACMSG *msg);
 
@@ -181,7 +181,7 @@ int main(int argc, char *argv[])
     return 0;
 }
 
-void print_help()
+void print_help(void)
 {
     printf(
         "Usage: router <init_method> [init_parameters]\n"
@@ -649,7 +649,7 @@ void init_port_threads(ROUTER_PORT *port_list)
     }
 }
 
-bool init_router()
+bool init_router(void)
 {
     MSGBOX_ID msgboxid;
     ROUTER_PORT *port;
@@ -687,7 +687,7 @@ bool init_router()
     return true;
 }
 
-void cleanup()
+void cleanup(void)
 {
     ROUTER_PORT *port;
     BACMSG msg;
@@ -801,7 +801,7 @@ uint16_t process_msg(BACMSG *msg, MSG_DATA *data, uint8_t **buff)
     return buff_len;
 }
 
-int kbhit()
+int kbhit(void)
 {
     static const int STDIN = 0;
     static bool initialized = false;
@@ -831,7 +831,7 @@ bool is_network_msg(BACMSG *msg)
     return control_byte & 0x80; /* check 7th bit */
 }
 
-uint16_t get_next_free_dnet()
+uint16_t get_next_free_dnet(void)
 {
     ROUTER_PORT *port = head;
     uint16_t i = 1;

apps/router/msgqueue.c

@@ -17,7 +17,7 @@
 
 pthread_mutex_t msg_lock = PTHREAD_MUTEX_INITIALIZER;
 
-MSGBOX_ID create_msgbox()
+MSGBOX_ID create_msgbox(void)
 {
     MSGBOX_ID msgboxid;
 

apps/router/msgqueue.h

@@ -55,8 +55,7 @@ typedef struct _msg_data {
     uint8_t ref_count;
 } MSG_DATA;
 
-MSGBOX_ID create_msgbox(
-    );
+MSGBOX_ID create_msgbox(void);
 
 /* returns sent byte count */
 bool send_to_msgbox(

apps/router/mstpmodule.c

@@ -27,7 +27,7 @@
 void *dl_mstp_thread(void *pArgs)
 {
     ROUTER_PORT *port = (ROUTER_PORT *)pArgs;
-    struct mstp_port_struct_t mstp_port = { (MSTP_RECEIVE_STATE)0 };
+    struct mstp_port_struct_t mstp_port = { 0 };
     volatile SHARED_MSTP_DATA shared_port_data = { 0 };
     uint16_t pdu_len;
     uint8_t shutdown = 0;