dali/bacnet_stack
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Fix couple compiler warnings (#737)

Browse Source 
* linux/bip6: Use function over PRINTF macro

Our repo should be C89 compatibale. C89 does not support variac macros.
For this reason use variac functions. This also enables to print
different streams than just stderr.

Also now if something is changed in debug_fprintf it also affect here
which is good.

* Use __inline__ over inline in library

Use __inline__ over inline as that is C89/C90 combatible. With MSVC we
need to use __inline so just define __inline__ to it if not already.

* h_get_alarm_sum: Fix -Wself-assign compiler warning

We get Wself-assign if PRINT_ENABLED is 0

```
src/bacnet/basic/service/h_get_alarm_sum.c:129:16:
  warning: explicitly assigning value of variable of type 'int' to itself
  [-Wself-assign]
[build]   129 |     bytes_sent = bytes_sent;
[build]       |     ~~~~~~~~~~ ^ ~~~~~~~~~~
```

---------

Co-authored-by: Kari Argillander <kari.argillander@fidelix.com>
This commit is contained in:
Kari Argillander
2024-08-21 17:44:31 +03:00
committed by GitHub
parent 5c20e6d505
commit d92edd359f
5 changed files with 41 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/bacnet/datalink/mstp.c
+4 -4
View File
@@ -44,7 +44,7 @@
#if defined(PRINT_ENABLED_RECEIVE)
#define printf_receive debug_printf
#else
static inline void printf_receive(const char *format, ...)
static __inline__ void printf_receive(const char *format, ...)
{
(void)format;
}
@@ -53,7 +53,7 @@ static inline void printf_receive(const char *format, ...)
#if defined(PRINT_ENABLED_RECEIVE_DATA)
#define printf_receive_data debug_printf
#else
static inline void printf_receive_data(const char *format, ...)
static __inline__ void printf_receive_data(const char *format, ...)
{
(void)format;
}
@@ -62,7 +62,7 @@ static inline void printf_receive_data(const char *format, ...)
#if defined(PRINT_ENABLED_RECEIVE_ERRORS)
#define printf_receive_error debug_printf
#else
static inline void printf_receive_error(const char *format, ...)
static __inline__ void printf_receive_error(const char *format, ...)
{
(void)format;
}
@@ -71,7 +71,7 @@ static inline void printf_receive_error(const char *format, ...)
#if defined(PRINT_ENABLED_MASTER)
#define printf_master debug_printf
#else
static inline void printf_master(const char *format, ...)
static __inline__ void printf_master(const char *format, ...)
{
(void)format;
}