cleaned up compiler warnings

2012-09-23 12:48:41 +00:00
parent 9db24ea90a
commit d5fd900780
9 changed files with 36 additions and 21 deletions
@@ -312,8 +312,13 @@ bool bacfile_write_property(
    len =
        bacapp_decode_application_data(wp_data->application_data,
        wp_data->application_data_len, &value);
+    if (len < 0) {
+        /* error while decoding - a value larger than we can handle */
+        wp_data->error_class = ERROR_CLASS_PROPERTY;
+        wp_data->error_code = ERROR_CODE_VALUE_OUT_OF_RANGE;
+        return false;
+    }
    /* FIXME: len < application_data_len: more data? */
-    /* FIXME: len == 0: unable to decode? */
    switch (wp_data->object_property) {
        case PROP_ARCHIVE:
            /* 12.13.8 Archive