cleaned up compiler warnings

bacnet-stack/demo/object/ao.c

@@ -405,7 +405,6 @@ bool Analog_Output_Write_Property(
 {
     bool status = false;        /* return value */
     unsigned int object_index = 0;
-    uint8_t level = AO_LEVEL_NULL;
     int len = 0;
     BACNET_APPLICATION_DATA_VALUE value;
 
@@ -451,7 +450,6 @@ bool Analog_Output_Write_Property(
                     WPValidateArgType(&value, BACNET_APPLICATION_TAG_NULL,
                     &wp_data->error_class, &wp_data->error_code);
                 if (status) {
-                    level = AO_LEVEL_NULL;
                     object_index =
                         Analog_Output_Instance_To_Index(wp_data->
                         object_instance);

bacnet-stack/demo/object/bacfile.c

@@ -312,8 +312,13 @@ bool bacfile_write_property(
     len =
         bacapp_decode_application_data(wp_data->application_data,
         wp_data->application_data_len, &value);
+    if (len < 0) {
+        /* error while decoding - a value larger than we can handle */
+        wp_data->error_class = ERROR_CLASS_PROPERTY;
+        wp_data->error_code = ERROR_CODE_VALUE_OUT_OF_RANGE;
+        return false;
+    }
     /* FIXME: len < application_data_len: more data? */
-    /* FIXME: len == 0: unable to decode? */
     switch (wp_data->object_property) {
         case PROP_ARCHIVE:
             /* 12.13.8 Archive

bacnet-stack/demo/object/ms-input.c

@@ -358,7 +358,6 @@ int Multistate_Input_Read_Property(
     BACNET_CHARACTER_STRING char_string;
     uint32_t present_value = 0;
     unsigned i = 0;
-    unsigned int object_index = 0;
     bool state = false;
     uint8_t *apdu = NULL;
 
@@ -435,9 +434,6 @@ int Multistate_Input_Read_Property(
             } else if (rpdata->array_index == BACNET_ARRAY_ALL) {
                 /* if no index was specified, then try to encode the entire list */
                 /* into one packet. */
-                object_index =
-                    Multistate_Input_Instance_To_Index(rpdata->
-                    object_instance);
                 for (i = 1; i <= MULTISTATE_NUMBER_OF_STATES; i++) {
                     characterstring_init_ansi(&char_string,
                         Multistate_Input_State_Text(rpdata->object_instance,
@@ -457,9 +453,6 @@ int Multistate_Input_Read_Property(
                     }
                 }
             } else {
-                object_index =
-                    Multistate_Input_Instance_To_Index(rpdata->
-                    object_instance);
                 if (rpdata->array_index <= MULTISTATE_NUMBER_OF_STATES) {
                     characterstring_init_ansi(&char_string,
                         Multistate_Input_State_Text(rpdata->object_instance,