diff --git a/bacnet-stack/demo/object/ai.c b/bacnet-stack/demo/object/ai.c index ccca7c5f..85251ee4 100644 --- a/bacnet-stack/demo/object/ai.c +++ b/bacnet-stack/demo/object/ai.c @@ -280,7 +280,14 @@ void Analog_Input_Change_Of_Value_Clear( } } -/* returns true if value has changed */ +/** + * For a given object instance-number, loads the value_list with the COV data. + * + * @param object_instance - object-instance number of the object + * @param value_list - list of COV data + * + * @return true if the value list is encoded + */ bool Analog_Input_Encode_Value_List( uint32_t object_instance, BACNET_PROPERTY_VALUE * value_list) @@ -320,8 +327,8 @@ bool Analog_Input_Encode_Value_List( value_list->value.next = NULL; value_list->priority = BACNET_NO_PRIORITY; value_list->next = NULL; + status = true; } - status = Analog_Input_Change_Of_Value(object_instance); return status; } diff --git a/bacnet-stack/demo/object/bi.c b/bacnet-stack/demo/object/bi.c index 10a9f132..abe43906 100644 --- a/bacnet-stack/demo/object/bi.c +++ b/bacnet-stack/demo/object/bi.c @@ -217,7 +217,14 @@ void Binary_Input_Change_Of_Value_Clear( return; } -/* returns true if value has changed */ +/** + * For a given object instance-number, loads the value_list with the COV data. + * + * @param object_instance - object-instance number of the object + * @param value_list - list of COV data + * + * @return true if the value list is encoded + */ bool Binary_Input_Encode_Value_List( uint32_t object_instance, BACNET_PROPERTY_VALUE * value_list) @@ -229,7 +236,7 @@ bool Binary_Input_Encode_Value_List( value_list->propertyArrayIndex = BACNET_ARRAY_ALL; value_list->value.context_specific = false; value_list->value.tag = BACNET_APPLICATION_TAG_ENUMERATED; - value_list->value.next = NULL; /* 2014.09.03 - edward@bac-test.com - added this, lack was causing exceptions under MSVC emulation */ + value_list->value.next = NULL; value_list->value.type.Enumerated = Binary_Input_Present_Value(object_instance); value_list->priority = BACNET_NO_PRIORITY; @@ -240,7 +247,7 @@ bool Binary_Input_Encode_Value_List( value_list->propertyArrayIndex = BACNET_ARRAY_ALL; value_list->value.context_specific = false; value_list->value.tag = BACNET_APPLICATION_TAG_BIT_STRING; - value_list->value.next = NULL; /* 2014.09.03 - edward@bac-test.com - added this, lack was causing exceptions under MSVC emulation */ + value_list->value.next = NULL; bitstring_init(&value_list->value.type.Bit_String); bitstring_set_bit(&value_list->value.type.Bit_String, STATUS_FLAG_IN_ALARM, false); @@ -256,9 +263,9 @@ bool Binary_Input_Encode_Value_List( STATUS_FLAG_OUT_OF_SERVICE, false); } value_list->priority = BACNET_NO_PRIORITY; - value_list->next = NULL; /* 2014.09.03 - edward@bac-test.com - added this, lack was causing exceptions under MSVC emulation */ + value_list->next = NULL; + status = true; } - status = Binary_Input_Change_Of_Value(object_instance); return status; }