Changed Ringbuf API: Ringbuf_Pop_Front is now Ringbuf_Pop, and now it copies the buffer into parameter and returns boolean. Original method was not safe since it returned a pointer to the element but freed the buffer element. Changed Ringbuf_Get_Front to Ringbuf_Peek with no change in functionality, to make names more consistent.

Updated all the MS/TP datalink layer implementations that use Ringbuf library.

bacnet-stack/src/mstp.c

@@ -1239,7 +1239,7 @@ static void Load_Input_Buffer(
     }
     /* empty any the existing data */
     while (!Ringbuf_Empty(&Test_Buffer)) {
-        (void) Ringbuf_Pop_Front(&Test_Buffer);
+        (void) Ringbuf_Pop(&Test_Buffer, NULL);
     }
 
     if (buffer) {
@@ -1257,11 +1257,12 @@ void RS485_Check_UART_Data(
     char *data;
     if (!Ringbuf_Empty(&Test_Buffer) && mstp_port &&
         (mstp_port->DataAvailable == false)) {
-        data = Ringbuf_Pop_Front(&Test_Buffer);
+        data = Ringbuf_Peek(&Test_Buffer);
         if (data) {
             mstp_port->DataRegister = *data;
             mstp_port->DataAvailable = true;
         }
+        (void)Ringbuf_Pop(&Test_Buffer, NULL);
     }
 }