From c9979f48bc7c2da7fa161c541f731e0def8934b3 Mon Sep 17 00:00:00 2001
From: Steve Karg <steve@kargs.net>
Date: Thu, 5 May 2022 13:57:20 -0500
Subject: [PATCH] Fix ports stm32f4xx IAR project warnings (#268)

Co-authored-by: Steve Karg <skarg@users.sourceforge.net>
---
 ports/stm32f4xx/bacnet.ewp |  8 ++++----
 ports/stm32f4xx/dlmstp.c   | 26 +++++++++++++++++++-------
 2 files changed, 23 insertions(+), 11 deletions(-)

diff --git a/ports/stm32f4xx/bacnet.ewp b/ports/stm32f4xx/bacnet.ewp
index 2f13cdbd..d49f1e6d 100644
--- a/ports/stm32f4xx/bacnet.ewp
+++ b/ports/stm32f4xx/bacnet.ewp
@@ -32,11 +32,11 @@
                 </option>
                 <option>
                     <name>Input description</name>
-                    <state>Automatic choice of formatter, without multibyte support.</state>
+                    <state>Full formatting, without multibyte support.</state>
                 </option>
                 <option>
                     <name>Output description</name>
-                    <state>Automatic choice of formatter, without multibyte support.</state>
+                    <state>Full formatting, without multibyte support.</state>
                 </option>
                 <option>
                     <name>GOutputBinary</name>
@@ -173,7 +173,7 @@
                 <option>
                     <name>OGPrintfVariant</name>
                     <version>0</version>
-                    <state>0</state>
+                    <state>1</state>
                 </option>
                 <option>
                     <name>OGPrintfMultibyteSupport</name>
@@ -182,7 +182,7 @@
                 <option>
                     <name>OGScanfVariant</name>
                     <version>0</version>
-                    <state>0</state>
+                    <state>1</state>
                 </option>
                 <option>
                     <name>OGScanfMultibyteSupport</name>
diff --git a/ports/stm32f4xx/dlmstp.c b/ports/stm32f4xx/dlmstp.c
index c6704de5..4557ea8d 100644
--- a/ports/stm32f4xx/dlmstp.c
+++ b/ports/stm32f4xx/dlmstp.c
@@ -577,9 +577,13 @@ static void MSTP_Receive_Frame_FSM(void)
                             /* if a frame-receipt callback was provided, call */
                             /* it for this frame */
                             if (Frame_Rx_Callback != NULL) {
-                                Frame_Rx_Callback(SourceAddress,
-                                    DestinationAddress, FrameType, InputBuffer,
-                                    DataLength);
+                                /* convert from volatile in defined order */
+                                uint8_t source, destination, frame;
+                                source = SourceAddress;
+                                destination = DestinationAddress;
+                                frame = FrameType;
+                                Frame_Rx_Callback(source, destination, 
+                                    frame, InputBuffer, DataLength);
                             }
                             /* wait for the start of the next frame. */
                             Receive_State = MSTP_RECEIVE_STATE_IDLE;
@@ -587,7 +591,10 @@ static void MSTP_Receive_Frame_FSM(void)
                             /* receive the data portion of the frame. */
                             if ((Address == This_Station) ||
                                 (Address == MSTP_BROADCAST_ADDRESS)) {
-                                if (DataLength <= InputBufferSize) {
+                                /* convert from volatile in defined order */
+                                uint32_t length;
+                                length = DataLength;
+                                if (length <= InputBufferSize) {
                                     /* Data */
                                     Receive_State = MSTP_RECEIVE_STATE_DATA;
                                 } else {
@@ -662,8 +669,13 @@ static void MSTP_Receive_Frame_FSM(void)
                         /* if a frame-receipt callback was provided, call it */
                         /* for this frame */
                         if (Frame_Rx_Callback != NULL) {
-                            Frame_Rx_Callback(SourceAddress, DestinationAddress,
-                                FrameType, InputBuffer, DataLength);
+                            /* convert from volatile in defined order */
+                            uint8_t source, destination, frame;
+                            source = SourceAddress;
+                            destination = DestinationAddress;
+                            frame = FrameType;
+                            Frame_Rx_Callback(source, destination,
+                                frame, InputBuffer, DataLength);
                         }
 
                     } else {
@@ -866,7 +878,7 @@ static bool MSTP_Master_Node_FSM(void)
                         /* ReceivedPFM */
                         destination = SourceAddress;
                         source = This_Station;
-                        if (DestinationAddress == This_Station) {
+                        if (DestinationAddress == source) {
                             MSTP_Send_Frame(FRAME_TYPE_REPLY_TO_POLL_FOR_MASTER,
                                 destination, source, NULL, 0);
                         }