Fix warnings found by splint (#324)

* Fix warnings found by splint

* Ignore Win32 Builder warnings about possible data loss for integers.

* Fix Windows build warnings

Co-authored-by: Steve Karg <skarg@users.sourceforge.net>

apps/readrange/main.c

@@ -203,6 +203,8 @@ int main(int argc, char *argv[])
     int count = 0;
     int hour, min, sec, hundredths;
     int year, month, day, wday;
+    unsigned object_type = 0;
+    unsigned object_property = 0;
     char *filename = NULL;
 
     filename = filename_remove_path(argv[0]);
@@ -228,15 +230,17 @@ int main(int argc, char *argv[])
     }
     /* decode the command line parameters */
     Target_Device_Object_Instance = strtol(argv[1], NULL, 0);
-    if (bactext_object_type_strtol(argv[2], &Target_Object_Type) == false) {
+    if (bactext_object_type_strtol(argv[2], &object_type) == false) {
         fprintf(stderr, "object-type=%s invalid\n", argv[2]);
         return 1;
     }
+    Target_Object_Type = object_type;
     Target_Object_Instance = strtol(argv[3], NULL, 0);
-    if (bactext_property_strtol(argv[4], &Target_Object_Property) == false) {
+    if (bactext_property_strtol(argv[4], &object_property) == false) {
         fprintf(stderr, "property=%s invalid\n", argv[4]);
         return 1;
     }
+    Target_Object_Property = object_property;
     Target_Object_Range_Type = strtol(argv[5], NULL, 0);
     /* some bounds checking */
     if (Target_Device_Object_Instance > BACNET_MAX_INSTANCE) {
@@ -356,7 +360,7 @@ int main(int argc, char *argv[])
         }
         if (Error_Detected) {
             break;
-}
+        }
         /* wait until the device is bound, or timeout and quit */
         if (!found) {
             found = address_bind_request(
@@ -396,9 +400,9 @@ int main(int argc, char *argv[])
         /* keep track of time for next check */
         last_seconds = current_seconds;
     }
-
     if (Error_Detected) {
         return 1;
-}
+    }
+
     return 0;
 }