dali/bacnet_stack
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix warnings found by splint (#324)

Browse Source 
* Fix warnings found by splint

* Ignore Win32 Builder warnings about possible data loss for integers.

* Fix Windows build warnings

Co-authored-by: Steve Karg <skarg@users.sourceforge.net>
This commit is contained in:
Steve Karg
2022-08-17 23:23:26 -05:00
committed by GitHub
parent 8cddaa5881
commit c8671d54f7
15 changed files with 79 additions and 51 deletions
Download Patch File Download Diff File Expand all files Collapse all files
apps/readprop/main.c
+9 -5
View File
@@ -252,6 +252,8 @@ int main(int argc, char *argv[])
BACNET_ADDRESS dest = { 0 };
bool specific_address = false;
int argi = 0;
unsigned object_type = 0;
unsigned object_property = 0;
unsigned int target_args = 0;
char *filename = NULL;
@@ -296,20 +298,22 @@ int main(int argc, char *argv[])
target_args++;
} else if (target_args == 1) {
if (bactext_object_type_strtol(
argv[argi], &Target_Object_Type) == false) {
argv[argi], &object_type) == false) {
fprintf(stderr, "object-type=%s invalid\n", argv[argi]);
return 1;
}
Target_Object_Type = object_type;
target_args++;
} else if (target_args == 2) {
Target_Object_Instance = strtol(argv[argi], NULL, 0);
target_args++;
} else if (target_args == 3) {
if (bactext_property_strtol(
argv[argi], &Target_Object_Property) == false) {
argv[argi], &object_property) == false) {
fprintf(stderr, "property=%s invalid\n", argv[argi]);
return 1;
}
Target_Object_Property = object_property;
target_args++;
} else if (target_args == 4) {
Target_Object_Index = strtol(argv[argi], NULL, 0);
@@ -399,7 +403,7 @@ int main(int argc, char *argv[])
}
if (Error_Detected) {
break;
}
}
/* wait until the device is bound, or timeout and quit */
if (!found) {
found = address_bind_request(
@@ -441,9 +445,9 @@ int main(int argc, char *argv[])
/* keep track of time for next check */
last_seconds = current_seconds;
}
if (Error_Detected) {
return 1;
}
}
return 0;
}