Added some function documentation and a little more support for Structured Views.

bacnet-stack/src/bacapp.c

@@ -517,6 +517,7 @@ BACNET_APPLICATION_TAG bacapp_context_tag_type(
             }
             break;
         case PROP_LIST_OF_GROUP_MEMBERS:
+        	/* Sequence of ReadAccessSpecification */
             switch (tag_number) {
                 case 0:
                     tag = BACNET_APPLICATION_TAG_OBJECT_ID;
@@ -555,6 +556,18 @@ BACNET_APPLICATION_TAG bacapp_context_tag_type(
                     break;
             }
             break;
+		case PROP_SUBORDINATE_LIST:
+			/* BACnetARRAY[N] of BACnetDeviceObjectReference */
+			switch (tag_number) {
+				case 0: /* Optional Device ID */
+				case 1: /* Object ID */
+					tag = BACNET_APPLICATION_TAG_OBJECT_ID;
+					break;
+				default:
+					break;
+			}
+			break;
+
         default:
             break;
     }

bacnet-stack/src/bactext.c

@@ -347,8 +347,8 @@ INDTEXT_DATA bacnet_property_names[] = {
     ,
     {PROP_FILE_TYPE, "file-type"}
     ,
-    {PROP_FIRMWARE_REVISION, "firmware-version"}
-    ,
+    {PROP_FIRMWARE_REVISION, "firmware-revision"}
+    ,					/* VTS wants "revision", not "version" */
     {PROP_HIGH_LIMIT, "high-limit"}
     ,
     {PROP_INACTIVE_TEXT, "inactive-text"}

bacnet-stack/src/rp.c

@@ -207,6 +207,18 @@ int rp_ack_encode_apdu(
     return apdu_len;
 }
 
+
+/** Decode the ReadProperty reply and store the result for one Property in a
+ *  BACNET_READ_PROPERTY_DATA structure.
+ *  This leaves the value(s) in the application_data buffer to be decoded later;
+ *  the application_data field points into the apdu buffer (is not allocated).
+ *
+ * @param apdu [in] The apdu portion of the ACK reply.
+ * @param apdu_len [in] The total length of the apdu.
+ * @param rpdata [out] The structure holding the partially decoded result.
+ * @return Number of decoded bytes (could be less than apdu_len),
+ * 			or -1 on decoding error.
+ */
 int rp_ack_decode_service_request(
     uint8_t * apdu,
     int apdu_len,       /* total length of the apdu */

bacnet-stack/src/tsm.c

@@ -282,7 +282,10 @@ void tsm_free_invoke_id(
     }
 }
 
-/* check if the invoke ID has been made free */
+/** Check if the invoke ID has been made free by the Transaction State Machine.
+ * @param invokeID [in] The invokeID to be checked, normally of last message sent.
+ * @return True if it is free (done with), False if still pending in the TSM.
+ */
 bool tsm_invoke_id_free(
     uint8_t invokeID)
 {
@@ -296,7 +299,12 @@ bool tsm_invoke_id_free(
     return status;
 }
 
-/* see if the invoke ID has failed get a confirmation */
+/** See if we failed get a confirmation for the message associated
+ *  with this invoke ID.
+ * @param invokeID [in] The invokeID to be checked, normally of last message sent.
+ * @return True if already failed, False if done or segmented or still waiting
+ *         for a confirmation.
+ */
 bool tsm_invoke_id_failed(
     uint8_t invokeID)
 {