Corrected octet string decoding in BACapp module for string length of zero. Added zeroes at the end of an octet string when initialized. Bug found by ptransfer unit test.

2012-05-12 15:39:16 +00:00
parent d0038e6456
commit c0f2af65e0
3 changed files with 26 additions and 13 deletions
@@ -635,8 +635,12 @@ bool octetstring_init(
        if (length <= MAX_OCTET_STRING_BYTES) {
            if (value) {
                for (i = 0; i < length; i++) {
-                    octet_string->value[octet_string->length] = value[i];
-                    octet_string->length++;
+                    if (i < length) {
+                        octet_string->value[octet_string->length] = value[i];
+                        octet_string->length++;
+                    } else {
+                        octet_string->value[i] = 0;
+                    }
                }
            } else {
                for (i = 0; i < MAX_OCTET_STRING_BYTES; i++) {