From bd29f1039d47a5cf98ca7937a32ec51c3fd95f7b Mon Sep 17 00:00:00 2001
From: Steve Karg <skarg@users.sourceforge.net>
Date: Sat, 7 Mar 2026 11:55:31 -0600
Subject: [PATCH] Fixed bacnet_strdup() to compile with C89/C90 without
 warnings.

---
 src/bacnet/bacstr.c | 17 ++++++++++-------
 1 file changed, 10 insertions(+), 7 deletions(-)

diff --git a/src/bacnet/bacstr.c b/src/bacnet/bacstr.c
index d75dcfa2..81135d7d 100644
--- a/src/bacnet/bacstr.c
+++ b/src/bacnet/bacstr.c
@@ -2196,13 +2196,16 @@ int bacnet_snprintf(
  */
 char *bacnet_strdup(const char *s)
 {
-    if (s == NULL) {
-        return NULL;
-    }
-    size_t size = strlen(s) + 1;
-    char *p = malloc(size);
-    if (p != NULL) {
-        memcpy(p, s, size);
+    size_t size;
+    char *p = NULL;
+
+    if (s) {
+        size = strlen(s) + 1;
+        p = malloc(size);
+        if (p != NULL) {
+            memcpy(p, s, size);
+        }
     }
+
     return p;
 }