Cleaning up code by adding prototypes or include files where required.

bacnet-stack/src/abort.c

@@ -35,6 +35,7 @@
 #include "bacenum.h"
 #include "bacdcode.h"
 #include "bacdef.h"
+#include "abort.h"
 
 /** @file abort.c  Abort Encoding/Decoding */
 /* Helper function to avoid needing additional entries in service data structures

bacnet-stack/src/bacaddr.c

@@ -36,6 +36,7 @@
 #include <stdbool.h>
 #include "config.h"
 #include "bacdef.h"
+#include "bacaddr.h"
 
 /** @file bacaddr.c  BACnet Address structure utilities */
 

bacnet-stack/src/bacerror.c

@@ -35,6 +35,7 @@
 #include "bacenum.h"
 #include "bacdcode.h"
 #include "bacdef.h"
+#include "bacerror.h"
 
 /** @file bacerror.c  Encode/Decode BACnet Errors */
 

bacnet-stack/src/bacint.c

@@ -37,6 +37,7 @@
 #include <stdint.h>
 #include <stdbool.h>
 #include "config.h"
+#include "bacint.h"
 
 /** @file bacint.c  Encode/Decode Integer Types */
 

bacnet-stack/src/bactext.c

@@ -35,6 +35,7 @@
 #include <stdio.h>
 #include "indtext.h"
 #include "bacenum.h"
+#include "bactext.h"
 
 /** @file bactext.c  Lookup or Translate BACnet Name Text */
 

bacnet-stack/src/bvlc.c

@@ -214,7 +214,7 @@ int bvlc_encode_write_bdt_init(
     return len;
 }
 
-int bvlc_encode_read_bdt(
+static int bvlc_encode_read_bdt(
     uint8_t * pdu)
 {
     int len = 0;
@@ -339,7 +339,7 @@ static int bvlc_encode_register_foreign_device(
     return len;
 }
 
-int bvlc_encode_read_fdt(
+static int bvlc_encode_read_fdt(
     uint8_t * pdu)
 {
     int len = 0;
@@ -417,7 +417,7 @@ static int bvlc_encode_read_fdt_ack(
     return pdu_len;
 }
 
-int bvlc_encode_delete_fdt_entry(
+static int bvlc_encode_delete_fdt_entry(
     uint8_t * pdu,
     struct in_addr *address,
     uint16_t port)
@@ -440,7 +440,7 @@ int bvlc_encode_delete_fdt_entry(
     return len;
 }
 
-int bvlc_encode_original_unicast_npdu(
+static int bvlc_encode_original_unicast_npdu(
     uint8_t * pdu,
     uint8_t * npdu,
     unsigned npdu_length)
@@ -466,7 +466,7 @@ int bvlc_encode_original_unicast_npdu(
     return len;
 }
 
-int bvlc_encode_original_broadcast_npdu(
+static int bvlc_encode_original_broadcast_npdu(
     uint8_t * pdu,
     uint8_t * npdu,
     unsigned npdu_length)
@@ -587,9 +587,9 @@ static bool bvlc_register_foreign_device(
                 (FD_Table[i].dest_port == ntohs(sin->sin_port))) {
                 status = true;
                 FD_Table[i].time_to_live = time_to_live;
-                /*  Upon receipt of a BVLL Register-Foreign-Device message, 
-                   a BBMD shall start a timer with a value equal to the 
-                   Time-to-Live parameter supplied plus a fixed grace 
+                /*  Upon receipt of a BVLL Register-Foreign-Device message,
+                   a BBMD shall start a timer with a value equal to the
+                   Time-to-Live parameter supplied plus a fixed grace
                    period of 30 seconds. */
                 FD_Table[i].seconds_remaining = time_to_live + 30;
                 break;

bacnet-stack/src/filename.c

@@ -33,6 +33,7 @@
 ####COPYRIGHTEND####*/
 #include <stdio.h>
 #include <string.h>
+#include "filename.h"
 
 /** @file filename.c  Function for filename manipulation */
 

bacnet-stack/src/memcopy.c

@@ -32,6 +32,7 @@
  -------------------------------------------
 ####COPYRIGHTEND####*/
 #include <stddef.h>
+#include "memcopy.h"
 
 /** @file memcopy.c  Custom memcopy function */
 

bacnet-stack/src/ptransfer.c

@@ -40,7 +40,7 @@
 /** @file ptransfer.c  Encode/Decode Private Transfer data */
 
 /* encode service */
-int pt_encode_apdu(
+static int pt_encode_apdu(
     uint8_t * apdu,
     uint16_t max_apdu,
     BACNET_PRIVATE_TRANSFER_DATA * private_data)