From b74af37720e9acf6fae069adf7c135dd53825f4b Mon Sep 17 00:00:00 2001 From: Steve Karg Date: Sun, 28 Sep 2025 21:35:23 -0500 Subject: [PATCH] Refactored CharacterString_Value_Out_Of_Service_Set() function to remove confusion about an assignment inside an if-statement. (#1113) --- src/bacnet/basic/object/csv.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/bacnet/basic/object/csv.c b/src/bacnet/basic/object/csv.c index 547ce6fb..cde636fc 100644 --- a/src/bacnet/basic/object/csv.c +++ b/src/bacnet/basic/object/csv.c @@ -382,12 +382,12 @@ void CharacterString_Value_Out_Of_Service_Set( if (pObject) { if (pObject->Out_Of_Service != value) { pObject->Changed = true; - /* Lets backup Present_Value when going Out_Of_Service or restore - * when going out of Out_Of_Service */ - if ((pObject->Out_Of_Service = value)) { + if (value) { + /* backup Present_Value when entering Out_Of_Service */ characterstring_copy( &pObject->Present_Value_Backup, &pObject->Present_Value); } else { + /* restore Present_Value when leaving Out_Of_Service */ characterstring_copy( &pObject->Present_Value, &pObject->Present_Value_Backup); }