From ab7462044946b85a6d234359a840fc8d91521452 Mon Sep 17 00:00:00 2001 From: Tomasz Kazimierz Motyl Date: Wed, 13 Nov 2024 14:26:46 +0000 Subject: [PATCH] Merge pull request #83 from se-apc/bugfix/fixing_error_condition_for__max_recipients_wp (#852) Fixing ERROR_CODE_NO_SPACE_TO_WRITE_PROPERTY condition Co-authored-by: Tomasz Kazimierz Motyl --- src/bacnet/basic/object/nc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/bacnet/basic/object/nc.c b/src/bacnet/basic/object/nc.c index 01d3d12c..4751921e 100644 --- a/src/bacnet/basic/object/nc.c +++ b/src/bacnet/basic/object/nc.c @@ -415,7 +415,8 @@ bool Notification_Class_Write_Property(BACNET_WRITE_PROPERTY_DATA *wp_data) } iOffset += len; /* Increasing element of list */ - if (++idx >= NC_MAX_RECIPIENTS) { + if ((++idx >= NC_MAX_RECIPIENTS) && + (iOffset < wp_data->application_data_len)) { wp_data->error_class = ERROR_CLASS_RESOURCES; wp_data->error_code = ERROR_CODE_NO_SPACE_TO_WRITE_PROPERTY; return false;