From a8e2b53aa0d06cff161d6722367c76ed83a5e9eb Mon Sep 17 00:00:00 2001 From: Steve Karg Date: Wed, 1 Apr 2026 22:28:05 -0400 Subject: [PATCH] Reverted unsigned decorator to BACNET_MAX_INSTANCE and BACNET_MAX_OBJECT constants since they are compared to signed values in some use cases which then fails when unsigned is promoted. --- src/bacnet/bacdef.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/bacnet/bacdef.h b/src/bacnet/bacdef.h index 663c059c..591a473c 100644 --- a/src/bacnet/bacdef.h +++ b/src/bacnet/bacdef.h @@ -152,10 +152,11 @@ typedef uint32_t BACNET_UNSIGNED_INTEGER; /* largest BACnet Instance Number */ /* Also used as a device instance number wildcard address */ -#define BACNET_MAX_INSTANCE (0x3FFFFFU) +/* note: used with signed and unsigned comparisons - don't decorate with 'u'*/ +#define BACNET_MAX_INSTANCE (0x3FFFFF) #define BACNET_INSTANCE_BITS 22 /* large BACnet Object Type */ -#define BACNET_MAX_OBJECT (0x3FFU) +#define BACNET_MAX_OBJECT (0x3FF) /* Array index 0=size of array, n=array element n, MAX=all array elements */ #define BACNET_ARRAY_ALL UINT32_MAX typedef uint32_t BACNET_ARRAY_INDEX;