Make most of functions const correct (#714)

* Make most of the functions const correct

Used clang-tidy and sonarlint to help find places where const could
pretty easily applied. Also lot of hand work.

This commit does not yet touch handlers and typedefs of those.

* Fix Arduino uno handler_who_is() has extra parenthesis

For some reason there is extra parenthesis. Remove it this is more
likely buildable.

* Bugfix/bacapp: Fix uninitilized array_index

We have changed bacapp_snprintf_value() to be const correct. After that
we got

```
/home/runner/work/bacnet-stack/bacnet-stack/src/bacnet/bacapp.c:3183:27: warning: 4th function call argument is an uninitialized value [core.CallAndMessage]
                ret_val = bacapp_snprintf_weeklyschedule(
                          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.
```

So analyzer could now spot that we do not actually initilize array_index
at all. Fix this by setting array_index to zero. Note that I actually do
not know if zeroing is right thing to do here. I choose zero as if this
has worked before it is most likely that it will work with zero value.

* cmake: Add and ignore Wwrite-strings compiler option

Wwrite-strings helps find places where const correctness is broken.

Example it will warn about these

```C

void func1(char* str);

func("test") /* "test" is const so we should not pass it to func1().

char* func2()
{
  return "test"; /* func2() should return const char*.
}
```

We still need to ignore it as not all are fixed but let's add it already
so we remember that it should be opened at some point.

---------

Co-authored-by: Kari Argillander <kari.argillander@fidelix.com>

src/bacnet/timestamp.h

@@ -43,41 +43,41 @@ extern "C" {
     BACNET_STACK_EXPORT
     void bacapp_timestamp_time_set(
         BACNET_TIMESTAMP * dest,
-        BACNET_TIME *btime);
+        const BACNET_TIME *btime);
 
     BACNET_STACK_EXPORT
     void bacapp_timestamp_datetime_set(
         BACNET_TIMESTAMP * dest,
-        BACNET_DATE_TIME * bdateTime);
+        const BACNET_DATE_TIME * bdateTime);
 
     BACNET_STACK_EXPORT
     void bacapp_timestamp_copy(
         BACNET_TIMESTAMP * dest,
-        BACNET_TIMESTAMP * src);
+        const BACNET_TIMESTAMP * src);
 
     BACNET_STACK_EXPORT
     bool bacapp_timestamp_same(
-        BACNET_TIMESTAMP *value1,
-        BACNET_TIMESTAMP *value2);
+        const BACNET_TIMESTAMP *value1,
+        const BACNET_TIMESTAMP *value2);
 
     BACNET_STACK_EXPORT
     int bacapp_encode_timestamp(
         uint8_t * apdu,
-        BACNET_TIMESTAMP * value);
+        const BACNET_TIMESTAMP * value);
     BACNET_STACK_EXPORT
     int bacapp_encode_context_timestamp(
         uint8_t * apdu,
         uint8_t tag_number,
-        BACNET_TIMESTAMP * value);
+        const BACNET_TIMESTAMP * value);
 
     BACNET_STACK_EXPORT
     int bacnet_timestamp_decode(
-        uint8_t * apdu,
+        const uint8_t * apdu,
         uint32_t apdu_size,
         BACNET_TIMESTAMP * value);
     BACNET_STACK_EXPORT
     int bacnet_timestamp_context_decode(
-        uint8_t * apdu,
+        const uint8_t * apdu,
         uint32_t apdu_size,
         uint8_t tag_number,
         BACNET_TIMESTAMP * value);
@@ -85,12 +85,12 @@ extern "C" {
     BACNET_STACK_DEPRECATED("Use bacnet_timestamp_decode() instead")
     BACNET_STACK_EXPORT
     int bacapp_decode_timestamp(
-        uint8_t * apdu,
+        const uint8_t * apdu,
         BACNET_TIMESTAMP * value);
     BACNET_STACK_DEPRECATED("Use bacnet_timestamp_context_decode() instead")
     BACNET_STACK_EXPORT
     int bacapp_decode_context_timestamp(
-        uint8_t * apdu,
+        const uint8_t * apdu,
         uint8_t tag_number,
         BACNET_TIMESTAMP * value);
 
@@ -102,7 +102,7 @@ extern "C" {
     int bacapp_timestamp_to_ascii(
         char *str,
         size_t str_size,
-        BACNET_TIMESTAMP *timestamp);
+        const BACNET_TIMESTAMP *timestamp);
 
 #ifdef __cplusplus
 }