dali/bacnet_stack
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Make most of functions const correct (#714)

Browse Source 
* Make most of the functions const correct

Used clang-tidy and sonarlint to help find places where const could
pretty easily applied. Also lot of hand work.

This commit does not yet touch handlers and typedefs of those.

* Fix Arduino uno handler_who_is() has extra parenthesis

For some reason there is extra parenthesis. Remove it this is more
likely buildable.

* Bugfix/bacapp: Fix uninitilized array_index

We have changed bacapp_snprintf_value() to be const correct. After that
we got

```
/home/runner/work/bacnet-stack/bacnet-stack/src/bacnet/bacapp.c:3183:27: warning: 4th function call argument is an uninitialized value [core.CallAndMessage]
                ret_val = bacapp_snprintf_weeklyschedule(
                          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.
```

So analyzer could now spot that we do not actually initilize array_index
at all. Fix this by setting array_index to zero. Note that I actually do
not know if zeroing is right thing to do here. I choose zero as if this
has worked before it is most likely that it will work with zero value.

* cmake: Add and ignore Wwrite-strings compiler option

Wwrite-strings helps find places where const correctness is broken.

Example it will warn about these

```C

void func1(char* str);

func("test") /* "test" is const so we should not pass it to func1().

char* func2()
{
  return "test"; /* func2() should return const char*.
}
```

We still need to ignore it as not all are fixed but let's add it already
so we remember that it should be opened at some point.

---------

Co-authored-by: Kari Argillander <kari.argillander@fidelix.com>
This commit is contained in:
Kari Argillander
2024-08-29 22:08:02 +03:00
committed by GitHub
parent 0177c59f4a
commit a2f1d6959d
408 changed files with 2608 additions and 2336 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/bacnet/cov.h
+17 -17
View File
@@ -54,18 +54,18 @@ extern "C" {
BACNET_STACK_EXPORT
size_t cov_notify_service_request_encode(
uint8_t *apdu, size_t apdu_size, BACNET_COV_DATA *data);
uint8_t *apdu, size_t apdu_size, const BACNET_COV_DATA *data);
BACNET_STACK_EXPORT
int cov_notify_encode_apdu(uint8_t *apdu, BACNET_COV_DATA *data);
int cov_notify_encode_apdu(uint8_t *apdu, const BACNET_COV_DATA *data);
BACNET_STACK_EXPORT
int ucov_notify_encode_apdu(
uint8_t *apdu, unsigned max_apdu_len, BACNET_COV_DATA *data);
uint8_t *apdu, unsigned max_apdu_len, const BACNET_COV_DATA *data);
BACNET_STACK_EXPORT
int ucov_notify_decode_apdu(
uint8_t *apdu, unsigned apdu_len, BACNET_COV_DATA *data);
const uint8_t *apdu, unsigned apdu_len, BACNET_COV_DATA *data);
BACNET_STACK_EXPORT
int ucov_notify_send(
@@ -75,10 +75,10 @@ BACNET_STACK_EXPORT
int ccov_notify_encode_apdu(uint8_t *apdu,
unsigned max_apdu_len,
uint8_t invoke_id,
BACNET_COV_DATA *data);
const BACNET_COV_DATA *data);
BACNET_STACK_EXPORT
int ccov_notify_decode_apdu(uint8_t *apdu,
int ccov_notify_decode_apdu(const uint8_t *apdu,
unsigned apdu_len,
uint8_t *invoke_id,
BACNET_COV_DATA *data);
@@ -86,47 +86,47 @@ int ccov_notify_decode_apdu(uint8_t *apdu,
/* common for both confirmed and unconfirmed */
BACNET_STACK_EXPORT
int cov_notify_decode_service_request(
uint8_t *apdu, unsigned apdu_len, BACNET_COV_DATA *data);
const uint8_t *apdu, unsigned apdu_len, BACNET_COV_DATA *data);
BACNET_STACK_EXPORT
int cov_subscribe_property_decode_service_request(
uint8_t *apdu, unsigned apdu_len, BACNET_SUBSCRIBE_COV_DATA *data);
const uint8_t *apdu, unsigned apdu_len, BACNET_SUBSCRIBE_COV_DATA *data);
BACNET_STACK_EXPORT
int cov_subscribe_property_apdu_encode(
uint8_t *apdu, BACNET_SUBSCRIBE_COV_DATA *data);
uint8_t *apdu, const BACNET_SUBSCRIBE_COV_DATA *data);
BACNET_STACK_EXPORT
size_t cov_subscribe_property_service_request_encode(
uint8_t *apdu, size_t apdu_size, BACNET_SUBSCRIBE_COV_DATA *data);
uint8_t *apdu, size_t apdu_size, const BACNET_SUBSCRIBE_COV_DATA *data);
BACNET_STACK_EXPORT
int cov_subscribe_property_encode_apdu(uint8_t *apdu,
unsigned max_apdu_len,
uint8_t invoke_id,
BACNET_SUBSCRIBE_COV_DATA *data);
const BACNET_SUBSCRIBE_COV_DATA *data);
BACNET_STACK_EXPORT
int cov_subscribe_decode_service_request(
uint8_t *apdu,
const uint8_t *apdu,
unsigned apdu_len,
BACNET_SUBSCRIBE_COV_DATA *data);
BACNET_STACK_EXPORT
int cov_subscribe_apdu_encode(uint8_t *apdu,
BACNET_SUBSCRIBE_COV_DATA *data);
const BACNET_SUBSCRIBE_COV_DATA *data);
BACNET_STACK_EXPORT
size_t cov_subscribe_service_request_encode(
uint8_t *apdu,
size_t apdu_size,
BACNET_SUBSCRIBE_COV_DATA *data);
const BACNET_SUBSCRIBE_COV_DATA *data);
BACNET_STACK_EXPORT
int cov_subscribe_encode_apdu(uint8_t *apdu,
unsigned max_apdu_len,
uint8_t invoke_id,
BACNET_SUBSCRIBE_COV_DATA *data);
const BACNET_SUBSCRIBE_COV_DATA *data);
BACNET_STACK_EXPORT
void cov_property_value_list_link(
@@ -168,14 +168,14 @@ bool cov_value_list_encode_signed_int(BACNET_PROPERTY_VALUE *value_list,
bool out_of_service);
BACNET_STACK_EXPORT
bool cov_value_list_encode_character_string(BACNET_PROPERTY_VALUE *value_list,
BACNET_CHARACTER_STRING *value,
const BACNET_CHARACTER_STRING *value,
bool in_alarm,
bool fault,
bool overridden,
bool out_of_service);
BACNET_STACK_EXPORT
bool cov_value_list_encode_bit_string(BACNET_PROPERTY_VALUE *value_list,
BACNET_BIT_STRING *value,
const BACNET_BIT_STRING *value,
bool in_alarm,
bool fault,
bool overridden,