dali/bacnet_stack
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Make most of functions const correct (#714)

Browse Source 
* Make most of the functions const correct

Used clang-tidy and sonarlint to help find places where const could
pretty easily applied. Also lot of hand work.

This commit does not yet touch handlers and typedefs of those.

* Fix Arduino uno handler_who_is() has extra parenthesis

For some reason there is extra parenthesis. Remove it this is more
likely buildable.

* Bugfix/bacapp: Fix uninitilized array_index

We have changed bacapp_snprintf_value() to be const correct. After that
we got

```
/home/runner/work/bacnet-stack/bacnet-stack/src/bacnet/bacapp.c:3183:27: warning: 4th function call argument is an uninitialized value [core.CallAndMessage]
                ret_val = bacapp_snprintf_weeklyschedule(
                          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.
```

So analyzer could now spot that we do not actually initilize array_index
at all. Fix this by setting array_index to zero. Note that I actually do
not know if zeroing is right thing to do here. I choose zero as if this
has worked before it is most likely that it will work with zero value.

* cmake: Add and ignore Wwrite-strings compiler option

Wwrite-strings helps find places where const correctness is broken.

Example it will warn about these

```C

void func1(char* str);

func("test") /* "test" is const so we should not pass it to func1().

char* func2()
{
  return "test"; /* func2() should return const char*.
}
```

We still need to ignore it as not all are fixed but let's add it already
so we remember that it should be opened at some point.

---------

Co-authored-by: Kari Argillander <kari.argillander@fidelix.com>
This commit is contained in:
Kari Argillander
2024-08-29 22:08:02 +03:00
committed by GitHub
parent 0177c59f4a
commit a2f1d6959d
408 changed files with 2608 additions and 2336 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/bacnet/cov.c
+17 -16
View File
@@ -27,11 +27,11 @@ Unconfirmed COV Notification
* @param data Pointer to the data to encode.
* @return number of bytes encoded, or zero on error.
*/
int cov_notify_encode_apdu(uint8_t *apdu, BACNET_COV_DATA *data)
int cov_notify_encode_apdu(uint8_t *apdu, const BACNET_COV_DATA *data)
{
int len = 0; /* length of each encoding */
int apdu_len = 0; /* total length of the apdu, return value */
BACNET_PROPERTY_VALUE *value = NULL; /* value in list */
const BACNET_PROPERTY_VALUE *value = NULL; /* value in list */
if (!data) {
return 0;
@@ -95,7 +95,7 @@ int cov_notify_encode_apdu(uint8_t *apdu, BACNET_COV_DATA *data)
* @return number of bytes encoded, or zero if unable to encode or too large
*/
size_t cov_notify_service_request_encode(
uint8_t *apdu, size_t apdu_size, BACNET_COV_DATA *data)
uint8_t *apdu, size_t apdu_size, const BACNET_COV_DATA *data)
{
size_t apdu_len = 0; /* total length of the apdu, return value */
@@ -122,7 +122,7 @@ size_t cov_notify_service_request_encode(
int ccov_notify_encode_apdu(uint8_t *apdu,
unsigned apdu_size,
uint8_t invoke_id,
BACNET_COV_DATA *data)
const BACNET_COV_DATA *data)
{
int len = 0; /* length of each encoding */
int apdu_len = 0; /* return value */
@@ -157,7 +157,7 @@ int ccov_notify_encode_apdu(uint8_t *apdu,
* @return number of bytes encoded, or zero if unable to encode or too large
*/
int ucov_notify_encode_apdu(
uint8_t *apdu, unsigned apdu_size, BACNET_COV_DATA *data)
uint8_t *apdu, unsigned apdu_size, const BACNET_COV_DATA *data)
{
int len = 0; /* length of each encoding */
int apdu_len = 0; /* return value */
@@ -201,7 +201,7 @@ int ucov_notify_encode_apdu(
* @return Bytes decoded or BACNET_STATUS_ERROR on error.
*/
int cov_notify_decode_service_request(
uint8_t *apdu, unsigned apdu_size, BACNET_COV_DATA *data)
const uint8_t *apdu, unsigned apdu_size, BACNET_COV_DATA *data)
{
int len = 0; /* return value */
int value_len = 0, tag_len = 0;
@@ -330,7 +330,8 @@ SubscribeCOV-Request ::= SEQUENCE {
* @param data Pointer to the data to encode.
* @return number of bytes encoded, or zero on error.
*/
int cov_subscribe_apdu_encode(uint8_t *apdu, BACNET_SUBSCRIBE_COV_DATA *data)
int cov_subscribe_apdu_encode(
uint8_t *apdu, const BACNET_SUBSCRIBE_COV_DATA *data)
{
int len = 0; /* length of each encoding */
int apdu_len = 0; /* total length of the apdu, return value */
@@ -380,7 +381,7 @@ int cov_subscribe_apdu_encode(uint8_t *apdu, BACNET_SUBSCRIBE_COV_DATA *data)
* @return number of bytes encoded, or zero if unable to encode or too large
*/
size_t cov_subscribe_service_request_encode(
uint8_t *apdu, size_t apdu_size, BACNET_SUBSCRIBE_COV_DATA *data)
uint8_t *apdu, size_t apdu_size, const BACNET_SUBSCRIBE_COV_DATA *data)
{
size_t apdu_len = 0; /* total length of the apdu, return value */
@@ -406,7 +407,7 @@ size_t cov_subscribe_service_request_encode(
int cov_subscribe_encode_apdu(uint8_t *apdu,
unsigned apdu_size,
uint8_t invoke_id,
BACNET_SUBSCRIBE_COV_DATA *data)
const BACNET_SUBSCRIBE_COV_DATA *data)
{
int len = 0; /* length of each encoding */
int apdu_len = 0; /* total length of the apdu, return value */
@@ -450,7 +451,7 @@ int cov_subscribe_encode_apdu(uint8_t *apdu,
* @return Bytes decoded or Zero/BACNET_STATUS_ERROR on error.
*/
int cov_subscribe_decode_service_request(
uint8_t *apdu, unsigned apdu_size, BACNET_SUBSCRIBE_COV_DATA *data)
const uint8_t *apdu, unsigned apdu_size, BACNET_SUBSCRIBE_COV_DATA *data)
{
int len = 0; /* return value */
int value_len = 0;
@@ -570,7 +571,7 @@ BACnetPropertyReference ::= SEQUENCE {
* @return bytes encoded or zero on error.
*/
int cov_subscribe_property_apdu_encode(
uint8_t *apdu, BACNET_SUBSCRIBE_COV_DATA *data)
uint8_t *apdu, const BACNET_SUBSCRIBE_COV_DATA *data)
{
int len = 0; /* length of each encoding */
int apdu_len = 0; /* total length of the apdu, return value */
@@ -649,7 +650,7 @@ int cov_subscribe_property_apdu_encode(
* @return number of bytes encoded, or zero if unable to encode or too large
*/
size_t cov_subscribe_property_service_request_encode(
uint8_t *apdu, size_t apdu_size, BACNET_SUBSCRIBE_COV_DATA *data)
uint8_t *apdu, size_t apdu_size, const BACNET_SUBSCRIBE_COV_DATA *data)
{
size_t apdu_len = 0; /* total length of the apdu, return value */
@@ -674,7 +675,7 @@ size_t cov_subscribe_property_service_request_encode(
int cov_subscribe_property_encode_apdu(uint8_t *apdu,
unsigned apdu_size,
uint8_t invoke_id,
BACNET_SUBSCRIBE_COV_DATA *data)
const BACNET_SUBSCRIBE_COV_DATA *data)
{
int len = 0; /* length of each encoding */
int apdu_len = 0; /* total length of the apdu, return value */
@@ -714,7 +715,7 @@ int cov_subscribe_property_encode_apdu(uint8_t *apdu,
* @return Bytes decoded or Zero/BACNET_STATUS_ERROR on error.
*/
int cov_subscribe_property_decode_service_request(
uint8_t *apdu, unsigned apdu_len, BACNET_SUBSCRIBE_COV_DATA *data)
const uint8_t *apdu, unsigned apdu_len, BACNET_SUBSCRIBE_COV_DATA *data)
{
int len = 0; /* return value */
uint8_t tag_number = 0;
@@ -1105,7 +1106,7 @@ bool cov_value_list_encode_signed_int(BACNET_PROPERTY_VALUE *value_list,
* @return true if values were encoded
*/
bool cov_value_list_encode_character_string(BACNET_PROPERTY_VALUE *value_list,
BACNET_CHARACTER_STRING *value,
const BACNET_CHARACTER_STRING *value,
bool in_alarm,
bool fault,
bool overridden,
@@ -1161,7 +1162,7 @@ bool cov_value_list_encode_character_string(BACNET_PROPERTY_VALUE *value_list,
* @return true if values were encoded
*/
bool cov_value_list_encode_bit_string(BACNET_PROPERTY_VALUE *value_list,
BACNET_BIT_STRING *value,
const BACNET_BIT_STRING *value,
bool in_alarm,
bool fault,
bool overridden,