Make most of functions const correct (#714)

* Make most of the functions const correct

Used clang-tidy and sonarlint to help find places where const could
pretty easily applied. Also lot of hand work.

This commit does not yet touch handlers and typedefs of those.

* Fix Arduino uno handler_who_is() has extra parenthesis

For some reason there is extra parenthesis. Remove it this is more
likely buildable.

* Bugfix/bacapp: Fix uninitilized array_index

We have changed bacapp_snprintf_value() to be const correct. After that
we got

```
/home/runner/work/bacnet-stack/bacnet-stack/src/bacnet/bacapp.c:3183:27: warning: 4th function call argument is an uninitialized value [core.CallAndMessage]
                ret_val = bacapp_snprintf_weeklyschedule(
                          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.
```

So analyzer could now spot that we do not actually initilize array_index
at all. Fix this by setting array_index to zero. Note that I actually do
not know if zeroing is right thing to do here. I choose zero as if this
has worked before it is most likely that it will work with zero value.

* cmake: Add and ignore Wwrite-strings compiler option

Wwrite-strings helps find places where const correctness is broken.

Example it will warn about these

```C

void func1(char* str);

func("test") /* "test" is const so we should not pass it to func1().

char* func2()
{
  return "test"; /* func2() should return const char*.
}
```

We still need to ignore it as not all are fixed but let's add it already
so we remember that it should be opened at some point.

---------

Co-authored-by: Kari Argillander <kari.argillander@fidelix.com>
This commit is contained in:
Kari Argillander
2024-08-29 22:08:02 +03:00
committed by GitHub
parent 0177c59f4a
commit a2f1d6959d
408 changed files with 2608 additions and 2336 deletions
+9 -8
View File
@@ -179,7 +179,7 @@ bool Time_Value_Present_Value(uint32_t object_instance, BACNET_TIME *value)
* @param value - floating point analog value
*/
static void Time_Value_Present_Value_COV_Detect(
struct object_data *pObject, BACNET_TIME *value)
struct object_data *pObject, const BACNET_TIME *value)
{
if (pObject && value) {
if (datetime_compare_time(&pObject->Present_Value, value) != 0) {
@@ -196,7 +196,8 @@ static void Time_Value_Present_Value_COV_Detect(
*
* @return true if values are within range and present-value is set.
*/
bool Time_Value_Present_Value_Set(uint32_t object_instance, BACNET_TIME *value)
bool Time_Value_Present_Value_Set(
uint32_t object_instance, const BACNET_TIME *value)
{
bool status = false;
struct object_data *pObject;
@@ -342,7 +343,7 @@ bool Time_Value_Object_Name(
*
* @return true if object-name was set
*/
bool Time_Value_Name_Set(uint32_t object_instance, char *new_name)
bool Time_Value_Name_Set(uint32_t object_instance, const char *new_name)
{
bool status = false; /* return value */
struct object_data *pObject;
@@ -382,15 +383,15 @@ const char *Time_Value_Name_ASCII(uint32_t object_instance)
*
* @return description text or NULL if not found
*/
char *Time_Value_Description(uint32_t object_instance)
const char *Time_Value_Description(uint32_t object_instance)
{
char *name = NULL;
struct object_data *pObject;
const char *name = NULL;
const struct object_data *pObject;
pObject = Keylist_Data(Object_List, object_instance);
if (pObject) {
if (pObject->Description) {
name = (char *)pObject->Description;
name = pObject->Description;
} else {
name = "";
}
@@ -407,7 +408,7 @@ char *Time_Value_Description(uint32_t object_instance)
*
* @return true if object-name was set
*/
bool Time_Value_Description_Set(uint32_t object_instance, char *new_name)
bool Time_Value_Description_Set(uint32_t object_instance, const char *new_name)
{
bool status = false; /* return value */
struct object_data *pObject;