Make most of functions const correct (#714)

* Make most of the functions const correct

Used clang-tidy and sonarlint to help find places where const could
pretty easily applied. Also lot of hand work.

This commit does not yet touch handlers and typedefs of those.

* Fix Arduino uno handler_who_is() has extra parenthesis

For some reason there is extra parenthesis. Remove it this is more
likely buildable.

* Bugfix/bacapp: Fix uninitilized array_index

We have changed bacapp_snprintf_value() to be const correct. After that
we got

```
/home/runner/work/bacnet-stack/bacnet-stack/src/bacnet/bacapp.c:3183:27: warning: 4th function call argument is an uninitialized value [core.CallAndMessage]
                ret_val = bacapp_snprintf_weeklyschedule(
                          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.
```

So analyzer could now spot that we do not actually initilize array_index
at all. Fix this by setting array_index to zero. Note that I actually do
not know if zeroing is right thing to do here. I choose zero as if this
has worked before it is most likely that it will work with zero value.

* cmake: Add and ignore Wwrite-strings compiler option

Wwrite-strings helps find places where const correctness is broken.

Example it will warn about these

```C

void func1(char* str);

func("test") /* "test" is const so we should not pass it to func1().

char* func2()
{
  return "test"; /* func2() should return const char*.
}
```

We still need to ignore it as not all are fixed but let's add it already
so we remember that it should be opened at some point.

---------

Co-authored-by: Kari Argillander <kari.argillander@fidelix.com>
This commit is contained in:
Kari Argillander
2024-08-29 22:08:02 +03:00
committed by GitHub
parent 0177c59f4a
commit a2f1d6959d
408 changed files with 2608 additions and 2336 deletions
+9 -9
View File
@@ -40,7 +40,7 @@ extern "C" {
BACNET_STACK_EXPORT
bool Network_Port_Name_Set(
uint32_t object_instance,
char *new_name);
const char *new_name);
BACNET_STACK_EXPORT
const char *Network_Port_Object_Name_ASCII(
uint32_t object_instance);
@@ -51,7 +51,7 @@ extern "C" {
BACNET_STACK_EXPORT
bool Network_Port_Description_Set(
uint32_t instance,
char *new_name);
const char *new_name);
BACNET_STACK_EXPORT
BACNET_RELIABILITY Network_Port_Reliability(
@@ -105,7 +105,7 @@ extern "C" {
BACNET_STACK_EXPORT
bool Network_Port_MAC_Address_Set(
uint32_t object_instance,
uint8_t *mac_src,
const uint8_t *mac_src,
uint8_t mac_len);
BACNET_STACK_EXPORT
@@ -308,7 +308,7 @@ extern "C" {
BACNET_STACK_EXPORT
bool Network_Port_Remote_BBMD_IP6_Address_Set(
uint32_t object_instance,
uint8_t *addr);
const uint8_t *addr);
BACNET_STACK_EXPORT
uint16_t Network_Port_Remote_BBMD_BIP6_Port(
uint32_t object_instance);
@@ -340,7 +340,7 @@ extern "C" {
BACNET_STACK_EXPORT
bool Network_Port_IPv6_Address_Set(
uint32_t object_instance,
uint8_t *ip_address);
const uint8_t *ip_address);
BACNET_STACK_EXPORT
bool Network_Port_IPv6_Multicast_Address(
@@ -349,7 +349,7 @@ extern "C" {
BACNET_STACK_EXPORT
bool Network_Port_IPv6_Multicast_Address_Set(
uint32_t object_instance,
uint8_t *ip_address);
const uint8_t *ip_address);
BACNET_STACK_EXPORT
uint8_t Network_Port_IPv6_Subnet_Prefix(
@@ -366,7 +366,7 @@ extern "C" {
BACNET_STACK_EXPORT
bool Network_Port_IPv6_Gateway_Set(
uint32_t object_instance,
uint8_t *ip_address);
const uint8_t *ip_address);
BACNET_STACK_EXPORT
bool Network_Port_IPv6_DNS_Server(
@@ -377,7 +377,7 @@ extern "C" {
bool Network_Port_IPv6_DNS_Server_Set(
uint32_t object_instance,
unsigned dns_index,
uint8_t *ip_address);
const uint8_t *ip_address);
BACNET_STACK_EXPORT
bool Network_Port_IPv6_DHCP_Server(
@@ -386,7 +386,7 @@ extern "C" {
BACNET_STACK_EXPORT
bool Network_Port_IPv6_DHCP_Server_Set(
uint32_t object_instance,
uint8_t *ip_address);
const uint8_t *ip_address);
BACNET_STACK_EXPORT
bool Network_Port_IPv6_Zone_Index(