Make most of functions const correct (#714)

* Make most of the functions const correct

Used clang-tidy and sonarlint to help find places where const could
pretty easily applied. Also lot of hand work.

This commit does not yet touch handlers and typedefs of those.

* Fix Arduino uno handler_who_is() has extra parenthesis

For some reason there is extra parenthesis. Remove it this is more
likely buildable.

* Bugfix/bacapp: Fix uninitilized array_index

We have changed bacapp_snprintf_value() to be const correct. After that
we got

```
/home/runner/work/bacnet-stack/bacnet-stack/src/bacnet/bacapp.c:3183:27: warning: 4th function call argument is an uninitialized value [core.CallAndMessage]
                ret_val = bacapp_snprintf_weeklyschedule(
                          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.
```

So analyzer could now spot that we do not actually initilize array_index
at all. Fix this by setting array_index to zero. Note that I actually do
not know if zeroing is right thing to do here. I choose zero as if this
has worked before it is most likely that it will work with zero value.

* cmake: Add and ignore Wwrite-strings compiler option

Wwrite-strings helps find places where const correctness is broken.

Example it will warn about these

```C

void func1(char* str);

func("test") /* "test" is const so we should not pass it to func1().

char* func2()
{
  return "test"; /* func2() should return const char*.
}
```

We still need to ignore it as not all are fixed but let's add it already
so we remember that it should be opened at some point.

---------

Co-authored-by: Kari Argillander <kari.argillander@fidelix.com>

src/bacnet/basic/object/lc.h

@@ -92,7 +92,7 @@ BACNET_STACK_EXPORT
 bool Load_Control_Object_Name(
     uint32_t object_instance, BACNET_CHARACTER_STRING *object_name);
 BACNET_STACK_EXPORT
-bool Load_Control_Name_Set(uint32_t object_instance, char *new_name);
+bool Load_Control_Name_Set(uint32_t object_instance, const char *new_name);
 BACNET_STACK_EXPORT
 const char *Load_Control_Name_ASCII(uint32_t object_instance);
 
@@ -103,7 +103,7 @@ BACNET_STACK_EXPORT
 bool Load_Control_Shed_Level_Array_Set(
     uint32_t object_instance,
     uint32_t array_index,
-    struct shed_level_data *value);
+    const struct shed_level_data *value);
 BACNET_STACK_EXPORT
 bool Load_Control_Shed_Level_Array(
     uint32_t object_instance,
@@ -133,7 +133,7 @@ bool Load_Control_Manipulated_Variable_Reference(
 BACNET_STACK_EXPORT
 bool Load_Control_Manipulated_Variable_Reference_Set(
     uint32_t object_instance,
-    BACNET_OBJECT_PROPERTY_REFERENCE *object_property_reference);
+    const BACNET_OBJECT_PROPERTY_REFERENCE *object_property_reference);
 
 BACNET_STACK_EXPORT
 void Load_Control_Manipulated_Object_Write_Callback_Set(
@@ -158,7 +158,7 @@ bool Load_Control_Write_Property(BACNET_WRITE_PROPERTY_DATA *wp_data);
 
 /* functions used for unit testing */
 BACNET_STACK_EXPORT
-void Load_Control_State_Machine(int object_index, BACNET_DATE_TIME *bdatetime);
+void Load_Control_State_Machine(int object_index, const BACNET_DATE_TIME *bdatetime);
 
 #ifdef __cplusplus
 }