Make most of functions const correct (#714)
* Make most of the functions const correct
Used clang-tidy and sonarlint to help find places where const could
pretty easily applied. Also lot of hand work.
This commit does not yet touch handlers and typedefs of those.
* Fix Arduino uno handler_who_is() has extra parenthesis
For some reason there is extra parenthesis. Remove it this is more
likely buildable.
* Bugfix/bacapp: Fix uninitilized array_index
We have changed bacapp_snprintf_value() to be const correct. After that
we got
```
/home/runner/work/bacnet-stack/bacnet-stack/src/bacnet/bacapp.c:3183:27: warning: 4th function call argument is an uninitialized value [core.CallAndMessage]
ret_val = bacapp_snprintf_weeklyschedule(
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.
```
So analyzer could now spot that we do not actually initilize array_index
at all. Fix this by setting array_index to zero. Note that I actually do
not know if zeroing is right thing to do here. I choose zero as if this
has worked before it is most likely that it will work with zero value.
* cmake: Add and ignore Wwrite-strings compiler option
Wwrite-strings helps find places where const correctness is broken.
Example it will warn about these
```C
void func1(char* str);
func("test") /* "test" is const so we should not pass it to func1().
char* func2()
{
return "test"; /* func2() should return const char*.
}
```
We still need to ignore it as not all are fixed but let's add it already
so we remember that it should be opened at some point.
---------
Co-authored-by: Kari Argillander <kari.argillander@fidelix.com>
This commit is contained in:
@@ -312,7 +312,7 @@ extern "C" {
|
||||
void);
|
||||
BACNET_STACK_EXPORT
|
||||
void Device_UUID_Set(
|
||||
uint8_t *new_uuid,
|
||||
const uint8_t *new_uuid,
|
||||
size_t length);
|
||||
BACNET_STACK_EXPORT
|
||||
void Device_UUID_Get(
|
||||
@@ -353,7 +353,7 @@ extern "C" {
|
||||
BACNET_CHARACTER_STRING * object_name);
|
||||
BACNET_STACK_EXPORT
|
||||
bool Device_Set_Object_Name(
|
||||
BACNET_CHARACTER_STRING * object_name);
|
||||
const BACNET_CHARACTER_STRING * object_name);
|
||||
/* Copy a child object name, given its ID. */
|
||||
BACNET_STACK_EXPORT
|
||||
bool Device_Object_Name_Copy(
|
||||
@@ -443,7 +443,7 @@ extern "C" {
|
||||
|
||||
BACNET_STACK_EXPORT
|
||||
bool Device_Valid_Object_Name(
|
||||
BACNET_CHARACTER_STRING * object_name,
|
||||
const BACNET_CHARACTER_STRING * object_name,
|
||||
BACNET_OBJECT_TYPE *object_type,
|
||||
uint32_t * object_instance);
|
||||
BACNET_STACK_EXPORT
|
||||
@@ -498,7 +498,7 @@ extern "C" {
|
||||
BACNET_STACK_EXPORT
|
||||
uint16_t Add_Routed_Device(
|
||||
uint32_t Object_Instance,
|
||||
BACNET_CHARACTER_STRING * Object_Name,
|
||||
const BACNET_CHARACTER_STRING * Object_Name,
|
||||
const char *Description);
|
||||
BACNET_STACK_EXPORT
|
||||
DEVICE_OBJECT_DATA *Get_Routed_Device_Object(
|
||||
@@ -511,16 +511,16 @@ extern "C" {
|
||||
bool Routed_Device_Address_Lookup(
|
||||
int idx,
|
||||
uint8_t address_len,
|
||||
uint8_t * mac_adress);
|
||||
const uint8_t * mac_adress);
|
||||
BACNET_STACK_EXPORT
|
||||
bool Routed_Device_GetNext(
|
||||
BACNET_ADDRESS * dest,
|
||||
int *DNET_list,
|
||||
const BACNET_ADDRESS * dest,
|
||||
const int *DNET_list,
|
||||
int *cursor);
|
||||
BACNET_STACK_EXPORT
|
||||
bool Routed_Device_Is_Valid_Network(
|
||||
uint16_t dest_net,
|
||||
int *DNET_list);
|
||||
const int *DNET_list);
|
||||
|
||||
BACNET_STACK_EXPORT
|
||||
uint32_t Routed_Device_Index_To_Instance(
|
||||
|
||||
Reference in New Issue
Block a user