Make most of functions const correct (#714)

* Make most of the functions const correct

Used clang-tidy and sonarlint to help find places where const could
pretty easily applied. Also lot of hand work.

This commit does not yet touch handlers and typedefs of those.

* Fix Arduino uno handler_who_is() has extra parenthesis

For some reason there is extra parenthesis. Remove it this is more
likely buildable.

* Bugfix/bacapp: Fix uninitilized array_index

We have changed bacapp_snprintf_value() to be const correct. After that
we got

```
/home/runner/work/bacnet-stack/bacnet-stack/src/bacnet/bacapp.c:3183:27: warning: 4th function call argument is an uninitialized value [core.CallAndMessage]
                ret_val = bacapp_snprintf_weeklyschedule(
                          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.
```

So analyzer could now spot that we do not actually initilize array_index
at all. Fix this by setting array_index to zero. Note that I actually do
not know if zeroing is right thing to do here. I choose zero as if this
has worked before it is most likely that it will work with zero value.

* cmake: Add and ignore Wwrite-strings compiler option

Wwrite-strings helps find places where const correctness is broken.

Example it will warn about these

```C

void func1(char* str);

func("test") /* "test" is const so we should not pass it to func1().

char* func2()
{
  return "test"; /* func2() should return const char*.
}
```

We still need to ignore it as not all are fixed but let's add it already
so we remember that it should be opened at some point.

---------

Co-authored-by: Kari Argillander <kari.argillander@fidelix.com>

src/bacnet/basic/binding/address.c

@@ -382,7 +382,7 @@ bool address_get_by_device(
  *
  * @return true/false
  */
-bool address_get_device_id(BACNET_ADDRESS *src, uint32_t *device_id)
+bool address_get_device_id(const BACNET_ADDRESS *src, uint32_t *device_id)
 {
     struct Address_Cache_Entry *pMatch;
     bool found = false; /* return value */
@@ -413,7 +413,8 @@ bool address_get_device_id(BACNET_ADDRESS *src, uint32_t *device_id)
  * @param max_apdu  Maximum APDU size.
  * @param src  Pointer to address structure to add.
  */
-void address_add(uint32_t device_id, unsigned max_apdu, BACNET_ADDRESS *src)
+void address_add(
+    uint32_t device_id, unsigned max_apdu, const BACNET_ADDRESS *src)
 {
     bool found = false; /* return value */
     struct Address_Cache_Entry *pMatch;
@@ -594,7 +595,7 @@ bool address_bind_request(
  * @param src  Pointer to the BACnet address.
  */
 void address_add_binding(
-    uint32_t device_id, unsigned max_apdu, BACNET_ADDRESS *src)
+    uint32_t device_id, unsigned max_apdu, const BACNET_ADDRESS *src)
 {
     struct Address_Cache_Entry *pMatch;
     unsigned index;

src/bacnet/basic/binding/address.h

@@ -38,7 +38,7 @@ extern "C" {
     void address_add(
         uint32_t device_id,
         unsigned max_apdu,
-        BACNET_ADDRESS * src);
+        const BACNET_ADDRESS * src);
 
     BACNET_STACK_EXPORT
     void address_remove_device(
@@ -67,7 +67,7 @@ extern "C" {
 
     BACNET_STACK_EXPORT
     bool address_get_device_id(
-        BACNET_ADDRESS * src,
+        const BACNET_ADDRESS * src,
         uint32_t * device_id);
 
     BACNET_STACK_EXPORT
@@ -91,7 +91,7 @@ extern "C" {
     void address_add_binding(
         uint32_t device_id,
         unsigned max_apdu,
-        BACNET_ADDRESS * src);
+        const BACNET_ADDRESS * src);
 
     BACNET_STACK_EXPORT
     int address_list_encode(