Make most of functions const correct (#714)
* Make most of the functions const correct
Used clang-tidy and sonarlint to help find places where const could
pretty easily applied. Also lot of hand work.
This commit does not yet touch handlers and typedefs of those.
* Fix Arduino uno handler_who_is() has extra parenthesis
For some reason there is extra parenthesis. Remove it this is more
likely buildable.
* Bugfix/bacapp: Fix uninitilized array_index
We have changed bacapp_snprintf_value() to be const correct. After that
we got
```
/home/runner/work/bacnet-stack/bacnet-stack/src/bacnet/bacapp.c:3183:27: warning: 4th function call argument is an uninitialized value [core.CallAndMessage]
ret_val = bacapp_snprintf_weeklyschedule(
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.
```
So analyzer could now spot that we do not actually initilize array_index
at all. Fix this by setting array_index to zero. Note that I actually do
not know if zeroing is right thing to do here. I choose zero as if this
has worked before it is most likely that it will work with zero value.
* cmake: Add and ignore Wwrite-strings compiler option
Wwrite-strings helps find places where const correctness is broken.
Example it will warn about these
```C
void func1(char* str);
func("test") /* "test" is const so we should not pass it to func1().
char* func2()
{
return "test"; /* func2() should return const char*.
}
```
We still need to ignore it as not all are fixed but let's add it already
so we remember that it should be opened at some point.
---------
Co-authored-by: Kari Argillander <kari.argillander@fidelix.com>
This commit is contained in:
+14
-10
@@ -62,31 +62,35 @@ extern "C" {
|
||||
#endif /* __cplusplus */
|
||||
|
||||
BACNET_STACK_EXPORT
|
||||
int bacnet_destination_encode(uint8_t *apdu, BACNET_DESTINATION *destination);
|
||||
int bacnet_destination_encode(
|
||||
uint8_t *apdu, const BACNET_DESTINATION *destination);
|
||||
BACNET_STACK_EXPORT
|
||||
int bacnet_destination_context_encode(
|
||||
uint8_t *apdu, uint8_t tag_number, BACNET_DESTINATION *destination);
|
||||
uint8_t *apdu, uint8_t tag_number, const BACNET_DESTINATION *destination);
|
||||
BACNET_STACK_EXPORT
|
||||
int bacnet_destination_decode(
|
||||
uint8_t *apdu, int apdu_len, BACNET_DESTINATION *destination);
|
||||
const uint8_t *apdu, int apdu_len, BACNET_DESTINATION *destination);
|
||||
BACNET_STACK_EXPORT
|
||||
void bacnet_destination_default_init(BACNET_DESTINATION *destination);
|
||||
BACNET_STACK_EXPORT
|
||||
bool bacnet_destination_default(BACNET_DESTINATION *destination);
|
||||
bool bacnet_destination_default(const BACNET_DESTINATION *destination);
|
||||
BACNET_STACK_EXPORT
|
||||
bool bacnet_destination_same(
|
||||
BACNET_DESTINATION *dest1, BACNET_DESTINATION *dest2);
|
||||
const BACNET_DESTINATION *dest1, const BACNET_DESTINATION *dest2);
|
||||
BACNET_STACK_EXPORT
|
||||
void bacnet_destination_copy(BACNET_DESTINATION *dest, BACNET_DESTINATION *src);
|
||||
void bacnet_destination_copy(
|
||||
BACNET_DESTINATION *dest, const BACNET_DESTINATION *src);
|
||||
|
||||
BACNET_STACK_EXPORT
|
||||
void bacnet_recipient_copy(BACNET_RECIPIENT *dest, BACNET_RECIPIENT *src);
|
||||
void bacnet_recipient_copy(
|
||||
BACNET_RECIPIENT *dest, const BACNET_RECIPIENT *src);
|
||||
BACNET_STACK_EXPORT
|
||||
bool bacnet_recipient_same(BACNET_RECIPIENT *r1, BACNET_RECIPIENT *r2);
|
||||
bool bacnet_recipient_same(
|
||||
const BACNET_RECIPIENT *r1, const BACNET_RECIPIENT *r2);
|
||||
BACNET_STACK_EXPORT
|
||||
bool bacnet_recipient_device_wildcard(BACNET_RECIPIENT *recipient);
|
||||
bool bacnet_recipient_device_wildcard(const BACNET_RECIPIENT *recipient);
|
||||
BACNET_STACK_EXPORT
|
||||
bool bacnet_recipient_device_valid(BACNET_RECIPIENT *recipient);
|
||||
bool bacnet_recipient_device_valid(const BACNET_RECIPIENT *recipient);
|
||||
|
||||
BACNET_STACK_EXPORT
|
||||
int bacnet_destination_to_ascii(
|
||||
|
||||
Reference in New Issue
Block a user