Make most of functions const correct (#714)

* Make most of the functions const correct

Used clang-tidy and sonarlint to help find places where const could
pretty easily applied. Also lot of hand work.

This commit does not yet touch handlers and typedefs of those.

* Fix Arduino uno handler_who_is() has extra parenthesis

For some reason there is extra parenthesis. Remove it this is more
likely buildable.

* Bugfix/bacapp: Fix uninitilized array_index

We have changed bacapp_snprintf_value() to be const correct. After that
we got

```
/home/runner/work/bacnet-stack/bacnet-stack/src/bacnet/bacapp.c:3183:27: warning: 4th function call argument is an uninitialized value [core.CallAndMessage]
                ret_val = bacapp_snprintf_weeklyschedule(
                          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.
```

So analyzer could now spot that we do not actually initilize array_index
at all. Fix this by setting array_index to zero. Note that I actually do
not know if zeroing is right thing to do here. I choose zero as if this
has worked before it is most likely that it will work with zero value.

* cmake: Add and ignore Wwrite-strings compiler option

Wwrite-strings helps find places where const correctness is broken.

Example it will warn about these

```C

void func1(char* str);

func("test") /* "test" is const so we should not pass it to func1().

char* func2()
{
  return "test"; /* func2() should return const char*.
}
```

We still need to ignore it as not all are fixed but let's add it already
so we remember that it should be opened at some point.

---------

Co-authored-by: Kari Argillander <kari.argillander@fidelix.com>

src/bacnet/bacaction.h

@@ -83,24 +83,28 @@ extern "C" {
 
 BACNET_STACK_EXPORT
 int bacnet_action_property_value_encode(
-    uint8_t *apdu, BACNET_ACTION_PROPERTY_VALUE *value);
+    uint8_t *apdu, const BACNET_ACTION_PROPERTY_VALUE *value);
 BACNET_STACK_EXPORT
 int bacnet_action_property_value_decode(
-    uint8_t *apdu, uint32_t apdu_size, BACNET_ACTION_PROPERTY_VALUE *value);
+    const uint8_t *apdu,
+    uint32_t apdu_size,
+    BACNET_ACTION_PROPERTY_VALUE *value);
 BACNET_STACK_EXPORT
 bool bacnet_action_property_value_same(
-    BACNET_ACTION_PROPERTY_VALUE *value1, BACNET_ACTION_PROPERTY_VALUE *value2);
+    const BACNET_ACTION_PROPERTY_VALUE *value1,
+    const BACNET_ACTION_PROPERTY_VALUE *value2);
 
 BACNET_STACK_EXPORT
-int bacnet_action_command_encode(uint8_t *apdu, BACNET_ACTION_LIST *entry);
+int bacnet_action_command_encode(
+    uint8_t *apdu, const BACNET_ACTION_LIST *entry);
 
 BACNET_STACK_EXPORT
 int bacnet_action_command_decode(
-    uint8_t *apdu, size_t apdu_size, BACNET_ACTION_LIST *entry);
+    const uint8_t *apdu, size_t apdu_size, BACNET_ACTION_LIST *entry);
 
 BACNET_STACK_EXPORT
 bool bacnet_action_command_same(
-    BACNET_ACTION_LIST *entry1, BACNET_ACTION_LIST *entry2);
+    const BACNET_ACTION_LIST *entry1, const BACNET_ACTION_LIST *entry2);
 
 #ifdef __cplusplus
 }