Make most of functions const correct (#714)

* Make most of the functions const correct

Used clang-tidy and sonarlint to help find places where const could
pretty easily applied. Also lot of hand work.

This commit does not yet touch handlers and typedefs of those.

* Fix Arduino uno handler_who_is() has extra parenthesis

For some reason there is extra parenthesis. Remove it this is more
likely buildable.

* Bugfix/bacapp: Fix uninitilized array_index

We have changed bacapp_snprintf_value() to be const correct. After that
we got

```
/home/runner/work/bacnet-stack/bacnet-stack/src/bacnet/bacapp.c:3183:27: warning: 4th function call argument is an uninitialized value [core.CallAndMessage]
                ret_val = bacapp_snprintf_weeklyschedule(
                          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.
```

So analyzer could now spot that we do not actually initilize array_index
at all. Fix this by setting array_index to zero. Note that I actually do
not know if zeroing is right thing to do here. I choose zero as if this
has worked before it is most likely that it will work with zero value.

* cmake: Add and ignore Wwrite-strings compiler option

Wwrite-strings helps find places where const correctness is broken.

Example it will warn about these

```C

void func1(char* str);

func("test") /* "test" is const so we should not pass it to func1().

char* func2()
{
  return "test"; /* func2() should return const char*.
}
```

We still need to ignore it as not all are fixed but let's add it already
so we remember that it should be opened at some point.

---------

Co-authored-by: Kari Argillander <kari.argillander@fidelix.com>

ports/esp32/src/ai.h

@@ -73,13 +73,13 @@ extern "C" {
         BACNET_CHARACTER_STRING * object_name);
     bool Analog_Input_Name_Set(
         uint32_t object_instance,
-        char *new_name);
+        const char *new_name);
 
-    char *Analog_Input_Description(
+    const char *Analog_Input_Description(
         uint32_t instance);
     bool Analog_Input_Description_Set(
         uint32_t instance,
-        char *new_name);
+        const char *new_name);
 
     bool Analog_Input_Units_Set(
         uint32_t instance,

ports/esp32/src/bip_init.c

@@ -15,7 +15,7 @@ long bip_get_addr_by_name(const char *host_name)
     return 0;
 }
 
-void bip_set_interface(char *ifname)
+void bip_set_interface(const char *ifname)
 {
 }
 

ports/esp32/src/bo.h

@@ -45,13 +45,13 @@ extern "C" {
         uint32_t object_instance,
         char *new_name);
 
-    char *Binary_Output_Description(
+    const char *Binary_Output_Description(
         uint32_t instance);
     bool Binary_Output_Description_Set(
         uint32_t instance,
-        char *new_name);
+        const char *new_name);
 
-    char *Binary_Output_Inactive_Text(
+    const char *Binary_Output_Inactive_Text(
         uint32_t instance);
     bool Binary_Output_Inactive_Text_Set(
         uint32_t instance,

ports/esp32/src/device.c

@@ -381,7 +381,7 @@ bool Device_Object_Name(
     return status;
 }
 
-bool Device_Set_Object_Name(BACNET_CHARACTER_STRING *object_name)
+bool Device_Set_Object_Name(const BACNET_CHARACTER_STRING *object_name)
 {
     bool status = false; /*return value */
 
@@ -689,7 +689,7 @@ bool Device_Object_List_Identifier(
  * Object.
  * @return True on success or else False if not found.
  */
-bool Device_Valid_Object_Name(BACNET_CHARACTER_STRING *object_name1,
+bool Device_Valid_Object_Name(const BACNET_CHARACTER_STRING *object_name1,
     BACNET_OBJECT_TYPE *object_type,
     uint32_t *object_instance)
 {

ports/esp32/src/device.h

@@ -274,7 +274,7 @@ extern "C" {
         uint32_t object_instance,
         BACNET_CHARACTER_STRING * object_name);
     bool Device_Set_Object_Name(
-        BACNET_CHARACTER_STRING * object_name);
+        const BACNET_CHARACTER_STRING * object_name);
     /* Copy a child object name, given its ID. */
     bool Device_Object_Name_Copy(
         BACNET_OBJECT_TYPE object_type,
@@ -340,7 +340,7 @@ extern "C" {
         void);
 
     bool Device_Valid_Object_Name(
-        BACNET_CHARACTER_STRING * object_name,
+        const BACNET_CHARACTER_STRING * object_name,
         BACNET_OBJECT_TYPE *object_type,
         uint32_t * object_instance);
     bool Device_Valid_Object_Id(
@@ -375,7 +375,7 @@ extern "C" {
 
     uint16_t Add_Routed_Device(
         uint32_t Object_Instance,
-        BACNET_CHARACTER_STRING * Object_Name,
+        const BACNET_CHARACTER_STRING * Object_Name,
         const char *Description);
     DEVICE_OBJECT_DATA *Get_Routed_Device_Object(
         int idx);
@@ -388,14 +388,14 @@ extern "C" {
     bool Routed_Device_Address_Lookup(
         int idx,
         uint8_t address_len,
-        uint8_t * mac_adress);
+        const uint8_t * mac_adress);
     bool Routed_Device_GetNext(
-        BACNET_ADDRESS * dest,
-        int *DNET_list,
+        const BACNET_ADDRESS * dest,
+        const int *DNET_list,
         int *cursor);
     bool Routed_Device_Is_Valid_Network(
         uint16_t dest_net,
-        int *DNET_list);
+        const int *DNET_list);
 
     uint32_t Routed_Device_Index_To_Instance(
         unsigned index);