From a1c6195fbbd4f1e16f2354069baaf7ef2a848ddd Mon Sep 17 00:00:00 2001
From: skarg <skarg@1e814d3a-8a88-4260-be86-c0dc25669c1e>
Date: Wed, 23 Mar 2005 18:49:04 +0000
Subject: [PATCH] added more test cases

---
 bacnet-stack/reject.c | 37 +++++++++++++++++++++++++++++--------
 1 file changed, 29 insertions(+), 8 deletions(-)

diff --git a/bacnet-stack/reject.c b/bacnet-stack/reject.c
index fe84bf06..63d09a68 100644
--- a/bacnet-stack/reject.c
+++ b/bacnet-stack/reject.c
@@ -75,6 +75,7 @@ int reject_decode_service_request(
   return len;
 }
 
+// decode the whole APDU - mainly used for unit testing
 int reject_decode_apdu(
   uint8_t *apdu,
   unsigned apdu_len,
@@ -86,15 +87,18 @@ int reject_decode_apdu(
   if (!apdu)
     return -1;
   // optional checking - most likely was already done prior to this call
-  if (apdu[0] != PDU_TYPE_REJECT)
-    return -1;
-  if (apdu_len > 1)
+  if (apdu_len)
   {
-    len = reject_decode_service_request(
-      &apdu[1],
-      apdu_len - 1,
-      invoke_id,
-      reject_reason);
+    if (apdu[0] != PDU_TYPE_REJECT)
+      return -1;
+    if (apdu_len > 1)
+    {
+      len = reject_decode_service_request(
+        &apdu[1],
+        apdu_len - 1,
+        invoke_id,
+        reject_reason);
+    }
   }
   
   return len;
@@ -140,6 +144,23 @@ void testReject(Test * pTest)
     &test_reject_reason);
   ct_test(pTest, len == -1);
 
+  // test NULL APDU
+  len = reject_decode_apdu(
+    NULL,
+    apdu_len,
+    &test_invoke_id,
+    &test_reject_reason);
+  ct_test(pTest, len == -1);
+
+  // force a zero length
+  len = reject_decode_apdu(
+    &apdu[0],
+    0,
+    &test_invoke_id,
+    &test_reject_reason);
+  ct_test(pTest, len == 0);
+  
+  
   // check them all...  
   for (
     invoke_id = 0;